From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <benoit.canet@irqsave.net>
Received: from paradis.irqsave.net
 (LPuteaux-656-1-25-125.w80-12.abo.wanadoo.fr [80.12.84.125])
 by dpdk.org (Postfix) with ESMTP id CCAAAAD9B
 for <dev@dpdk.org>; Wed, 18 Feb 2015 08:59:23 +0100 (CET)
Received: from irqsave.net (laure.irqsave.net [192.168.77.2])
 by paradis.irqsave.net (Postfix) with ESMTP id 865CC11A805;
 Wed, 18 Feb 2015 08:59:23 +0100 (CET)
Date: Wed, 18 Feb 2015 08:59:23 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
To: huawei.xie@intel.com, dev@dpdk.org
Message-ID: <20150218075923.GA23117@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: [dpdk-dev] Vhost-user early adopter feedback
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Feb 2015 07:59:24 -0000


Hello Xie,

As promized I integrated your vhost-user patchset from january in my vswitch.

I just tried it, it works pretty well.

I just had a minor bug with rte_vhost_driver_register taking ownership of the
string patch pointer too late. I freed it out of habit just after registering in the
caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I
allocated later. Maybe an early strdup() would fix this.

The last patch of your new version is really a great idea since it will
simplify a lot the socket creation and management code.

Best regards

Benoît