* [dpdk-dev] Vhost-user early adopter feedback
@ 2015-02-18 7:59 Benoît Canet
2015-02-25 7:46 ` Xie, Huawei
0 siblings, 1 reply; 3+ messages in thread
From: Benoît Canet @ 2015-02-18 7:59 UTC (permalink / raw)
To: huawei.xie, dev
Hello Xie,
As promized I integrated your vhost-user patchset from january in my vswitch.
I just tried it, it works pretty well.
I just had a minor bug with rte_vhost_driver_register taking ownership of the
string patch pointer too late. I freed it out of habit just after registering in the
caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I
allocated later. Maybe an early strdup() would fix this.
The last patch of your new version is really a great idea since it will
simplify a lot the socket creation and management code.
Best regards
Benoît
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] Vhost-user early adopter feedback
2015-02-18 7:59 [dpdk-dev] Vhost-user early adopter feedback Benoît Canet
@ 2015-02-25 7:46 ` Xie, Huawei
2015-02-25 11:32 ` Benoît Canet
0 siblings, 1 reply; 3+ messages in thread
From: Xie, Huawei @ 2015-02-25 7:46 UTC (permalink / raw)
To: Benoît Canet; +Cc: dev
On 2/18/2015 3:59 PM, Benoît Canet wrote:
> Hello Xie,
>
> As promized I integrated your vhost-user patchset from january in my vswitch.
>
> I just tried it, it works pretty well.
>
> I just had a minor bug with rte_vhost_driver_register taking ownership of the
> string patch pointer too late. I freed it out of habit just after registering in the
> caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I
> allocated later. Maybe an early strdup() would fix this.
Thanks.
Do you mean we duplicate a string from the first parameter path, like
vserver->path = strdup(path) ?
If this was the case, it was ever in my mind. We would do this if
necessary.
>
> The last patch of your new version is really a great idea since it will
> simplify a lot the socket creation and management code.
>
> Best regards
>
> Benoît
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] Vhost-user early adopter feedback
2015-02-25 7:46 ` Xie, Huawei
@ 2015-02-25 11:32 ` Benoît Canet
0 siblings, 0 replies; 3+ messages in thread
From: Benoît Canet @ 2015-02-25 11:32 UTC (permalink / raw)
To: Xie, Huawei; +Cc: dev
The Wednesday 25 Feb 2015 à 07:46:56 (+0000), Xie, Huawei wrote :
> On 2/18/2015 3:59 PM, Benoît Canet wrote:
> > Hello Xie,
> >
> > As promized I integrated your vhost-user patchset from january in my vswitch.
> >
> > I just tried it, it works pretty well.
> >
> > I just had a minor bug with rte_vhost_driver_register taking ownership of the
> > string patch pointer too late. I freed it out of habit just after registering in the
> > caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I
> > allocated later. Maybe an early strdup() would fix this.
> Thanks.
> Do you mean we duplicate a string from the first parameter path, like
> vserver->path = strdup(path) ?
Yes I was thinking about this.
Best regards
Benoît
> If this was the case, it was ever in my mind. We would do this if
> necessary.
> >
> > The last patch of your new version is really a great idea since it will
> > simplify a lot the socket creation and management code.
> >
> > Best regards
> >
> > Benoît
> >
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-25 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 7:59 [dpdk-dev] Vhost-user early adopter feedback Benoît Canet
2015-02-25 7:46 ` Xie, Huawei
2015-02-25 11:32 ` Benoît Canet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).