From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 9F681B5B2 for ; Thu, 19 Feb 2015 14:07:37 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YOQpJ-0003Ny-1S; Thu, 19 Feb 2015 08:07:35 -0500 Date: Thu, 19 Feb 2015 08:07:32 -0500 From: Neil Horman To: "Ananyev, Konstantin" Message-ID: <20150219130732.GD24069@hmsreliant.think-freely.org> References: <2601191342CEEE43887BDE71AB977258213F0CA8@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB977258213F0CA8@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 13:07:37 -0000 On Thu, Feb 19, 2015 at 12:02:06PM +0000, Ananyev, Konstantin wrote: > Hi Panu, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen > > Sent: Thursday, February 19, 2015 10:25 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 > > > > Add extra parenthesis to remove ambiguity on what we want to compare, > > otherwise gcc 5 issues a "logical not is only applied to the left hand > > side of comparison" warning which with -Werror fails the build. > > > > Signed-off-by: Panu Matilainen > > --- > > lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c > > index 37e5bae..93a6a00 100644 > > --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c > > +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c > > @@ -2898,8 +2898,8 @@ STATIC s32 ixgbe_fc_autoneg_fiber(struct ixgbe_hw *hw) > > */ > > > > linkstat = IXGBE_READ_REG(hw, IXGBE_PCS1GLSTA); > > - if ((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE) == 0) || > > - (!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT) == 1)) { > > + if (((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE)) == 0) || > > + ((!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT)) == 1)) { > > ERROR_REPORT1(IXGBE_ERROR_POLLING, > > "Auto-Negotiation did not complete or timed out"); > > goto out; > > Unfortunately we are not supposed to change files under ixgbe subfirectory (except ixgbe_osdep.*). > Usually we deal with it just by: > If GCC_VERSION... > CFLAGS_ixgbe_common.o += -Wno... > Why don't you just send a patch to the netdev list to fix ixgbe in the linux tree, and then apply the same patch once it gets accepted. Then the merge will go smoothly when it comes down. That would be much better than doing GCC version ifdeffery. Neil > You can have a look at lib/librte_pmd_ixgbe/Makefile, there are plenty of such things. > Konstantin > > > > -- > > 2.1.0 > >