From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CB2CCAD7F for ; Thu, 19 Feb 2015 16:21:35 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 19 Feb 2015 07:21:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,609,1418112000"; d="scan'208";a="456800748" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.37]) by FMSMGA003.fm.intel.com with SMTP; 19 Feb 2015 07:06:23 -0800 Received: by (sSMTP sendmail emulation); Thu, 19 Feb 2015 15:21:30 +0025 Date: Thu, 19 Feb 2015 15:21:30 +0000 From: Bruce Richardson To: Yerden Zhumabekov Message-ID: <20150219152129.GA17032@bricha3-MOBL3> References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <20150201141356.GA3141@localhost.localdomain> <54CEEA01.3090600@sts.kz> <20150202033122.GA18728@neilslaptop.think-freely.org> <54CF0D86.3090507@sts.kz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54CF0D86.3090507@sts.kz> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 15:21:36 -0000 On Mon, Feb 02, 2015 at 11:39:18AM +0600, Yerden Zhumabekov wrote: > > 02.02.2015 9:31, Neil Horman пишет: > > On Mon, Feb 02, 2015 at 09:07:45AM +0600, Yerden Zhumabekov wrote: > > > >> I think so, I've just successfully built it against latest snapshot with > >> RTE_TARGET > >> equal to 'x86_64-native-linuxapp-gcc'. > >> > > Please confirm that setting the machine type to default builds and runs properly. > > If I understood you correctly, I set CONFIG_RTE_MACHINE="default" in the > config and the build was successful. > Confirmed, this worked for me too. Looking at the patches, they look good. However, one thing I think we are missing is a unit test to verify that all our CRC implementations give the same result. That would be useful as a sanity check of the software fallback especially. The existing hash tests, test the hash table implementation rather than the mathematical argorithm used to compute the hash values. Overall, though, software fallback for CRC is something well worthwhile having. Series Acked-by: Bruce Richardson > -- > Sincerely, > > Yerden Zhumabekov > State Technical Service > Astana, KZ > >