From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id A1132B55A
 for <dev@dpdk.org>; Fri, 20 Feb 2015 11:15:22 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga102.fm.intel.com with ESMTP; 20 Feb 2015 02:15:20 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,613,1418112000"; d="scan'208";a="457176743"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.37])
 by FMSMGA003.fm.intel.com with SMTP; 20 Feb 2015 02:00:08 -0800
Received: by  (sSMTP sendmail emulation); Fri, 20 Feb 2015 10:15:18 +0025
Date: Fri, 20 Feb 2015 10:15:18 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150220101517.GB17276@bricha3-MOBL3>
References: <1424365731-32228-1-git-send-email-danny.zhou@intel.com>
 <1424365731-32228-2-git-send-email-danny.zhou@intel.com>
 <61932075.MLJK3iMSUs@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <61932075.MLJK3iMSUs@xps13>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: enable uio_pci_generic support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Feb 2015 10:15:23 -0000

On Fri, Feb 20, 2015 at 10:01:10AM +0100, Thomas Monjalon wrote:
> Hi Danny,
> 
> 2015-02-20 01:08, Zhou Danny:
> > @@ -148,6 +151,7 @@ struct rte_pci_device {
> >  	struct rte_pci_id id;                   /**< PCI ID. */
> >  	struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE];   /**< PCI Memory Resource */
> >  	struct rte_intr_handle intr_handle;     /**< Interrupt handle */
> > +	char kernel_driver_name[BUFSIZ];        /**< Kernel driver name */
> 
> The comment is not very helpful.
> What about something like "Kernel driver to map ressources in userspace"?
> 
> You are introducing a new field without filling it for UIO and VFIO.
> 
> Testuya and Michael are working on the same thing in hotplug patchset:
> 	http://dpdk.org/dev/patchwork/patch/3520/
> Please help to choose the best approach.
> 
> >  	const struct rte_pci_driver *driver;    /**< Associated driver */
>
Hi Thomas,
since Danny is now off on Chinese New Year break, I'll look into this and see
about sending an updated patch set if I can today.

Regards,
/Bruce