From: Stephen Hemminger <stephen@networkplumber.org>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Make -Werror optional
Date: Fri, 20 Feb 2015 17:55:21 -0800 [thread overview]
Message-ID: <20150220175521.334a63c9@urahara> (raw)
In-Reply-To: <54DCBEB4.30005@redhat.com>
On Thu, 12 Feb 2015 16:54:44 +0200
Panu Matilainen <pmatilai@redhat.com> wrote:
> On 02/12/2015 04:38 PM, Stephen Hemminger wrote:
> > On Thu, 12 Feb 2015 13:13:22 +0200
> > Panu Matilainen <pmatilai@redhat.com> wrote:
> >
> >> This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable
> >> fail-on-warning compile behavior, defaulting to off.
> >>
> >> Failing build on warnings is a useful developer tool but its bad
> >> for release tarballs which can and do get built with newer
> >> compilers than what was used/available during development. Compilers
> >> routinely add new warnings so code which built silently with cc X
> >> might no longer do so with X+1. This doesn't make the existing code
> >> any more buggier and failing the build in this case does not help
> >> not help improve code quality of an already released version either.
Hopefully distro's like RHEL will build with -Werror enabled
and not allow build to go through with errors.
next prev parent reply other threads:[~2015-02-21 1:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 11:13 Panu Matilainen
2015-02-12 11:25 ` Bruce Richardson
2015-02-12 12:02 ` Panu Matilainen
2015-02-12 12:08 ` Bruce Richardson
2015-02-12 13:58 ` Panu Matilainen
2015-02-12 14:02 ` Bruce Richardson
2015-02-12 14:05 ` Thomas Monjalon
2015-02-12 15:18 ` [dpdk-dev] [PATCH v2] mk: Only default to -Werror when building from git checkout Panu Matilainen
2015-02-20 12:15 ` Thomas Monjalon
2015-02-21 2:15 ` Stephen Hemminger
2015-02-21 10:48 ` Thomas Monjalon
2016-03-02 14:22 ` [dpdk-dev] [PATCH v3] mk: stop on warning only in developer build Thomas Monjalon
2016-03-02 22:04 ` Bruce Richardson
2016-03-03 10:36 ` Thomas Monjalon
2016-03-03 10:53 ` Panu Matilainen
2015-02-12 14:38 ` [dpdk-dev] [PATCH] Make -Werror optional Stephen Hemminger
2015-02-12 14:54 ` Panu Matilainen
2015-02-21 1:55 ` Stephen Hemminger [this message]
2015-02-21 19:33 ` Neil Horman
2015-02-23 8:19 ` Panu Matilainen
2015-02-23 13:55 ` Neil Horman
2015-02-23 14:20 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220175521.334a63c9@urahara \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).