From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id C5927B3EB for ; Sat, 21 Feb 2015 03:15:46 +0100 (CET) Received: by pablf10 with SMTP id lf10so12294413pab.12 for ; Fri, 20 Feb 2015 18:15:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=KR7lC6I4nB0BjXEZIQfvh7N+MH/JEf23ZmTob7kUiv4=; b=Hrrb/D147xGb/3gkV+7vFGgZWbMqA8rntkdMSAV1hRV1+IboelDI6Q0kLxUqjbnH+G WDNoBIyV+yfmLuutUhkMK3tmyoxg2RKAH12XfLz+hUSSmWWn0xDD8Qb0qNjQTAVyZK+H BCojvG6My43AkucVPk3dHM7IhJgLrC/BtwAhTIw4GQsZQJcaX4rp+sasbBmBjlQS35wA 0G/pyEsJA2akE/Y1H3eZyH1L7obbdiFPCrDd7lN13MhC10mHRUu3IuhXTVoDGpW1PUr4 q0z+87v6OUpipPO8aow0wBUAYbKMed3plpo0DfDsCaDmZ+tAGxQcobMPEp32Wgi2+zEE smEA== X-Gm-Message-State: ALoCoQlWuWK3jodgsiFjvlMmBvOp6nweC0ae6Xsoxf8OEqrbag9CJ3jmNFkvaqjbYiLQXhGCcugu X-Received: by 10.66.241.71 with SMTP id wg7mr865441pac.81.1424484946125; Fri, 20 Feb 2015 18:15:46 -0800 (PST) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id ps6sm24529196pbb.94.2015.02.20.18.15.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 18:15:45 -0800 (PST) Date: Fri, 20 Feb 2015 18:15:40 -0800 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20150220181540.3b97dc86@urahara> In-Reply-To: <9190554.3JBlDK3N1R@xps13> References: <54DCB16F.7080104@redhat.com> <65cbd71d3b5b45f469a2fe67fe8b0def4bddebbd.1423754231.git.pmatilai@redhat.com> <9190554.3JBlDK3N1R@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: Only default to -Werror when building from git checkout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 02:15:47 -0000 On Fri, 20 Feb 2015 13:15:38 +0100 Thomas Monjalon wrote: > 2015-02-12 17:18, Panu Matilainen: > > Add RTE_DEVEL_BUILD make-variable which can be used to do things > > differently when doing development vs building a release, > > autodetected from source root .git presence and overridable via > > commandline. Use it to only enable -Werror compiler flag when > > building a git checkout: > > > > Failing build on warnings is a useful developer tool but its bad > > for release tarballs which can and do get built with newer > > compilers than what was used/available during development. Compilers > > routinely add new warnings so code which built silently with cc X > > might no longer do so with X+1. This doesn't make the existing code > > any more buggier and failing the build in this case does not help > > not help improve code quality of an already released version either. > > Please, could you update documentation to explain RTE_DEVEL_BUILD option? > Some users could try to build from git, so we should advise to disable RTE_DEVEL_BUILD. > These files might be updated: > http://dpdk.org/browse/dpdk/tree/doc/build-sdk-quick.txt > http://dpdk.org/browse/dpdk/tree/doc/guides/linux_gsg/build_dpdk.rst > http://dpdk.org/browse/dpdk/tree/doc/guides/freebsd_gsg/build_dpdk.rst > http://dpdk.org/browse/dpdk/tree/doc/guides/prog_guide/dev_kit_build_system.rst > > Thanks Also do not allow any patches to into upstream that cause new warnings with latest stable version of Gcc or Clang? I don't want a clean project to get littered with warning graffiti. Maybe a build bot?