From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 55039ADCA for ; Sun, 22 Feb 2015 21:32:00 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 22 Feb 2015 12:24:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,626,1418112000"; d="scan'208";a="458050404" Received: from omishael-mobl.ger.corp.intel.com ([10.252.18.211]) by FMSMGA003.fm.intel.com with SMTP; 22 Feb 2015 12:16:36 -0800 Received: by (sSMTP sendmail emulation); Sun, 22 Feb 2015 20:31:55 +0025 Date: Sun, 22 Feb 2015 20:31:55 +0000 From: Bruce Richardson To: David Marchand Message-ID: <20150222203155.GB6840@bricha3-MOBL3> References: <54E9695A.5010509@igel.co.jp> <3376494.YE1J4OXSVA@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Testpmd returns error. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Feb 2015 20:32:00 -0000 On Sun, Feb 22, 2015 at 06:51:58PM +0000, Richardson, Bruce wrote: > > > > > On 22 Feb 2015, at 16:19, David Marchand > wrote: > > Hello, > > On Sun, Feb 22, 2015 at 3:17 PM, Thomas Monjalon > wrote: > Hi Tetsuya, > > > Someone, could you please check it? > > It is possible that this patchset was not correctly tested. > We might revert it or try to fix it. > I think the decision should be done by its authors (Danny, Bruce), > or the Linux EAL maintainer (David). > > Well, I need to have a deeper look at this change. > I did not find time before my holidays. > > - I think there may be an issue with the use of resource0 instead of /dev/uio. > I am not sure uio mmap will be happy or I overlooked something trivial. > > - Testing proc type in pci_uio_map_resource() looks wrong to me, since we validated earlier in this same function that we are in primary process. > > - uio_res->maps indexes are not the same as the pci resources, might trigger problems (and it clearly does not make it easy to read ...). > And now we are reading sysfs twice. > I would prefer this code is reworked so that we avoid those loops in eal_pci_uio.c. > > > Anyway, I am still on holiday (I should have kept my laptop away ...), I will be back tomorrow. > I suppose Bruce or Danny will come with a fix, let's decide what the best solution is at this moment. > > > > I'll take another look at this but unfortunately I don't think I can necessarily reproduce this issue as it seems to occur with enic driver, but I will try. Please ignore above from me, now that I'm able to read my mail on more than a phone screen, I can actually read things properly... :-) I'll look into this now, see if it's something simple I can spot to fix. /Bruce > > -- > David Marchand