From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ig0-f176.google.com (mail-ig0-f176.google.com
 [209.85.213.176]) by dpdk.org (Postfix) with ESMTP id 48FD8ADDB
 for <dev@dpdk.org>; Mon, 23 Feb 2015 17:00:37 +0100 (CET)
Received: by mail-ig0-f176.google.com with SMTP id hl2so19191279igb.3
 for <dev@dpdk.org>; Mon, 23 Feb 2015 08:00:36 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=EMzCYfWrQHvDqLeG4ouBK4GysnrdXwkqrhyD6bG0tfY=;
 b=Fz04/eKNOATOFpmDmX38MyODwrUSKwQORVtYL1mWbR+LOZu90UpmtRkN4pSpGpXQqm
 eFQLtPpbt/9MrRxHUIyUASIfgno6b00uyzoVFvhsFOYsA7bJlRoVsy4m0RlSOJgcGNrV
 9Ldqs/40VmADhSwxeqZE5Pwsl+Dt3YQVaQn6c8iorMt5Iaoalf7gbfC8kxodGxT7mJWX
 fQm23Yd7bgrMdI7HI/+YkrsClGmnHEIabIM1ZwtEbSXrDr305Ibr46cyFLN+JdqQG99R
 dD1HePleiYvKAJ35gjO3cB78uYO5TqvzFim3rA5ANiAmvUVgTnTzxpgNeGrTgAH7Ph3O
 kEJQ==
X-Gm-Message-State: ALoCoQk7vzOZNeaAV9HP2zkV1oziAVbNDJVSLFtptIZPrS0HbC0MfCCP0UQGqXV4C1TIB9hl2X/v
X-Received: by 10.107.166.146 with SMTP id p140mr14126052ioe.61.1424707236226; 
 Mon, 23 Feb 2015 08:00:36 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id l1sm16250894iod.19.2015.02.23.08.00.35
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Feb 2015 08:00:36 -0800 (PST)
Date: Mon, 23 Feb 2015 08:00:35 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Message-ID: <20150223080035.001417e8@urahara>
In-Reply-To: <1424700600-1765-6-git-send-email-pawelx.wodkowski@intel.com>
References: <1424700600-1765-1-git-send-email-pawelx.wodkowski@intel.com>
 <1424700600-1765-6-git-send-email-pawelx.wodkowski@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/5] Fix usage of fgets in various places
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2015 16:00:37 -0000

On Mon, 23 Feb 2015 15:10:00 +0100
Pawel Wodkowski <pawelx.wodkowski@intel.com> wrote:

> Declaration of fgets() is
> char *fgets(char *str, int size, FILE *stream);
> 
> Klocwork complain about passing "sizeof()" as size parameter since
> implicit casting size_t to int might cause loss of precision.
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>

NAK this is shooting at Unicorns.
The tool is the problem not the code.