From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4B448ADB2 for ; Tue, 24 Feb 2015 11:54:02 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 24 Feb 2015 02:48:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,638,1418112000"; d="scan'208";a="531991270" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.32]) by orsmga003.jf.intel.com with SMTP; 24 Feb 2015 02:44:56 -0800 Received: by (sSMTP sendmail emulation); Tue, 24 Feb 2015 10:53:57 +0025 Date: Tue, 24 Feb 2015 10:53:57 +0000 From: Bruce Richardson To: david.marchand@6wind.com Message-ID: <20150224105357.GD8416@bricha3-MOBL3> References: <1424703444-30761-1-git-send-email-bruce.richardson@intel.com> <1424710955-10896-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424710955-10896-1-git-send-email-bruce.richardson@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 10:54:02 -0000 On Mon, Feb 23, 2015 at 05:02:33PM +0000, Bruce Richardson wrote: > This patch does some cleanup of the uio mapping code to > a) fix issue with mmap of PCI bars reported by Tetsuya and confirmed > by others. > b) eliminate redundant code and reduce scans of /sys > > > Bruce Richardson (2): > eal: mmap uio resources using resourceX files > eal: populate uio_maps from pci mem_resources array > > lib/librte_eal/common/include/rte_pci.h | 2 +- > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 + > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 173 +++++++++++------------------ > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + > 4 files changed, 66 insertions(+), 111 deletions(-) > > -- > 2.1.0 > Hi David, Given your previous suggestions on the uio_pic_generic code, I'd appreciate any feedback you could provide on this patchset. Regards, /Bruce