From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ie0-f173.google.com (mail-ie0-f173.google.com
 [209.85.223.173]) by dpdk.org (Postfix) with ESMTP id 42CC29AC1
 for <dev@dpdk.org>; Tue, 24 Feb 2015 20:01:41 +0100 (CET)
Received: by iecrd18 with SMTP id rd18so34712605iec.5
 for <dev@dpdk.org>; Tue, 24 Feb 2015 11:01:40 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=7vIPjqOWfekCy8t8DSSXav5bAie+S2IUdGSJ/mdqgyI=;
 b=YBbQ8+KE5wxi0xACgqYBAPnQm+9FABF72rrwjNOFy0DxxojikFg2omWA/kZjCHKDhR
 64QyRff2BmVTgOiEql+JeO4w1de6omFS0qF3Y/40H74Uj8QvblmWMuyYx8iB1jfv9YJh
 QDW++5rV10rcFApflv5psf7Gw9vLaVQJgBmR4mt6QZvUdhHRgZPmqCCZm17ahsDyofMH
 DSbZGLetaR8ElYY4xevLngIku9F8WGueoQHALx7uhvzRbTBPYnEbIFHITzsAnI0iKfmS
 e1HnRMoyIArO9OabgsQsVizg2NQ6Pu1fT8KwbPkyPodFeuXIyfim1EeOMRMqi7vMTtqV
 TcMQ==
X-Gm-Message-State: ALoCoQll8Bt4XOkH87GjmdLL9a3h1GgzyQ+V+KC9BtytqQ7d68su84km8/sIHtmrC5L8nuys0FJJ
X-Received: by 10.107.150.149 with SMTP id y143mr22559648iod.22.1424804500546; 
 Tue, 24 Feb 2015 11:01:40 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id f1sm8408034igt.14.2015.02.24.11.01.39
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 24 Feb 2015 11:01:40 -0800 (PST)
Date: Tue, 24 Feb 2015 11:01:43 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <20150224110143.6be781f4@urahara>
In-Reply-To: <54EC4261.6050804@redhat.com>
References: <1424700600-1765-1-git-send-email-pawelx.wodkowski@intel.com>
 <1424700600-1765-6-git-send-email-pawelx.wodkowski@intel.com>
 <20150223080035.001417e8@urahara> <54EC4261.6050804@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/5] Fix usage of fgets in various places
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2015 19:01:41 -0000

On Tue, 24 Feb 2015 11:20:33 +0200
Panu Matilainen <pmatilai@redhat.com> wrote:

> The tool is technically correct, even if loss of precision might be 
> unlikely to occur in this context

Overflow is not there in the code.
That is why I said "shooting Unicorns"; this is all about
about fixing bugs that don't exist because there is nothing there
in the real world.

In this code buffer is always something normal in size and does
not exceed 2^32-1.