From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) by dpdk.org (Postfix) with ESMTP id 079522E8A for ; Tue, 24 Feb 2015 20:18:57 +0100 (CET) Received: by mail-ig0-f179.google.com with SMTP id l13so29652819iga.0 for ; Tue, 24 Feb 2015 11:18:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=LeZjx0nEVefmvqaP9Q/qem0ntGv9YRqueCegsUlmw5w=; b=PRb89b+HRO0DJ9mLBLjDj7aAfkfARuOIe9rXQmwm/3I9SGUu6Tjca2Q3fJjBJ9YHxS YZwLLsNQ2vPekQBveCBUoHlw4ZbEa/N9FEKpMmglq83UlQvERLs8QwvBwtAsOOF179ie bfttvWGc8pfmNfVUJu97XgUlOnLHY8PgsLdiFqCBrrFarryvSytQ555Ay7yxspczebLP 81yU4Ig/Q/OovzD5xE4X0jS2CMi3q3cOIEe8xIXPAsyh9O39UtgrS9dEZbiDIktgEDDW CrJzKCriIbhr1kyBOAawKThIAxaOGdor1rPc16IKV+yXDff8quujXyaELS2hgAwoIiUN A45A== X-Gm-Message-State: ALoCoQnkag2UXPb9eeaFrV1cA1GEiZbMFcly9Uy+pgsaQamE/jJQ/e+6AZUpljyuC45rp4JrXzKq X-Received: by 10.50.25.225 with SMTP id f1mr21940302igg.29.1424805536464; Tue, 24 Feb 2015 11:18:56 -0800 (PST) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id f142sm9498863ioe.3.2015.02.24.11.18.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 11:18:56 -0800 (PST) Date: Tue, 24 Feb 2015 11:18:52 -0800 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20150224111852.42253352@urahara> In-Reply-To: References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org> <20150205124330.GB28355@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 19:18:57 -0000 On Mon, 23 Feb 2015 23:51:31 +0000 Thomas Monjalon wrote: > 2015-02-05 07:43, Neil Horman: > > On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote: > > > + > > > +/** > > > + * Hierarchical scheduler subport statistics reset > > > + * > > > + * @param port > > > + * Handle to port scheduler instance > > > + * @param subport_id > > > + * Subport ID > > > + * @return > > > + * 0 upon success, error code otherwise > > > + */ > > > +int > > > +rte_sched_subport_stats_reset(struct rte_sched_port *port, > > > + uint32_t subport_id); > > > + > > > /** > > > * Hierarchical scheduler queue statistics read > > > * > > > @@ -338,6 +353,20 @@ rte_sched_queue_read_stats(struct rte_sched_port *port, > > > struct rte_sched_queue_stats *stats, > > > uint16_t *qlen); > > > > > > +/** > > > + * Hierarchical scheduler queue statistics reset > > > + * > > > + * @param port > > > + * Handle to port scheduler instance > > > + * @param queue_id > > > + * Queue ID within port scheduler > > > + * @return > > > + * 0 upon success, error code otherwise > > > + */ > > > +int > > > +rte_sched_queue_stats_reset(struct rte_sched_port *port, > > > + uint32_t queue_id); > > > + > > Both need to be added to the version map to expose them properly. > > Neil > > Stephen, this patchset is partially acked and could enter in 2.0.0-rc1. > May you send a v3 addressing comments? Or should I break the serie by > applying only some of them? Or postpone the serie to 2.1? I can resend v3. Wasn't clear that a conclusion was reached. IMHO read should not clear.