From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 04246ADB0 for ; Tue, 24 Feb 2015 12:32:51 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 24 Feb 2015 03:32:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,638,1418112000"; d="scan'208";a="532004811" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.32]) by orsmga003.jf.intel.com with SMTP; 24 Feb 2015 03:23:46 -0800 Received: by (sSMTP sendmail emulation); Tue, 24 Feb 2015 11:32:47 +0025 Date: Tue, 24 Feb 2015 11:32:47 +0000 From: Bruce Richardson To: David Marchand Message-ID: <20150224113247.GE8416@bricha3-MOBL3> References: <1424703444-30761-1-git-send-email-bruce.richardson@intel.com> <1424710955-10896-1-git-send-email-bruce.richardson@intel.com> <20150224105357.GD8416@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 11:32:52 -0000 On Tue, Feb 24, 2015 at 12:23:15PM +0100, David Marchand wrote: > Hello Bruce, > > On Tue, Feb 24, 2015 at 11:53 AM, Bruce Richardson < > bruce.richardson@intel.com> wrote: > > > On Mon, Feb 23, 2015 at 05:02:33PM +0000, Bruce Richardson wrote: > > > This patch does some cleanup of the uio mapping code to > > > a) fix issue with mmap of PCI bars reported by Tetsuya and confirmed > > > by others. > > > b) eliminate redundant code and reduce scans of /sys > > > > > > > > > Bruce Richardson (2): > > > eal: mmap uio resources using resourceX files > > > eal: populate uio_maps from pci mem_resources array > > > > > > lib/librte_eal/common/include/rte_pci.h | 2 +- > > > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 + > > > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 173 > > +++++++++++------------------ > > > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + > > > 4 files changed, 66 insertions(+), 111 deletions(-) > > > > > > -- > > > 2.1.0 > > > > > Given your previous suggestions on the uio_pic_generic code, I'd appreciate > > any feedback you could provide on this patchset. > > > Well, I only have one pending question on the use of resourceX files > instead of /dev/uioX. > You rely on sysfs mmap code for pci resources. > Is this really equivalent to uio mmap operations ? uio_pci_generic provides no mappings via /dev/uioX, so the may to mmap the bars using uio_pci_generic is via the sysfs. [1] > If you can ensure me this won't break igb_uio setups, then these patches > are ok for me. Since igb_uio is based on the same uio_pci_generic framework, what works for uio_pci_generic should work for igb_uio also - and testing indicates that this works. Danny could perhaps provide better insights than I can into any guarantees as to not breaking things, but I've tested this on a couple of platforms with 1G and 10G NICs using both igb_uio and uio_pci_generic, both individually and in combination. I've also verified multiprocess support and done a quick sanity test with 32-bit. Everything seems ok in testing thus far. > > Thanks for the cleanup in eal_pci_uio.c. > No problem. > > -- > David Marchand /Bruce [1]: https://lkml.org/lkml/2012/3/20/375