From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <benoit.canet@irqsave.net>
Received: from paradis.irqsave.net
 (LPuteaux-656-1-25-125.w80-12.abo.wanadoo.fr [80.12.84.125])
 by dpdk.org (Postfix) with ESMTP id 87797959
 for <dev@dpdk.org>; Wed, 25 Feb 2015 12:32:33 +0100 (CET)
Received: from irqsave.net (laure.irqsave.net [192.168.77.2])
 by paradis.irqsave.net (Postfix) with ESMTP id 5EDA911D6D9;
 Wed, 25 Feb 2015 12:32:33 +0100 (CET)
Date: Wed, 25 Feb 2015 12:32:32 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
To: "Xie, Huawei" <huawei.xie@intel.com>
Message-ID: <20150225113232.GA21663@irqsave.net>
References: <20150218075923.GA23117@irqsave.net>
 <C37D651A908B024F974696C65296B57B0F3A436D@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <C37D651A908B024F974696C65296B57B0F3A436D@SHSMSX101.ccr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Vhost-user early adopter feedback
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2015 11:32:33 -0000

The Wednesday 25 Feb 2015 à 07:46:56 (+0000), Xie, Huawei wrote :
> On 2/18/2015 3:59 PM, Benoît Canet wrote:
> > Hello Xie,
> >
> > As promized I integrated your vhost-user patchset from january in my vswitch.
> >
> > I just tried it, it works pretty well.
> >
> > I just had a minor bug with rte_vhost_driver_register taking ownership of the
> > string patch pointer too late. I freed it out of habit just after registering in the
> > caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I
> > allocated later. Maybe an early strdup() would fix this.
> Thanks.
> Do you mean we duplicate a string from the first parameter path, like
> vserver->path = strdup(path) ?

Yes I was thinking about this.

Best regards

Benoît

> If this was the case, it was ever in my mind. We would do this if
> necessary.

> >
> > The last patch of your new version is really a great idea since it will
> > simplify a lot the socket creation and management code.
> >
> > Best regards
> >
> > Benoît
> >
> >
>