Re: [dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map

[Neil Horman <nhorman@tuxdriver.com>]

On Wed, Feb 25, 2015 at 02:39:33PM +0100, Thomas Monjalon wrote:
> 2015-02-25 07:30, Neil Horman:
> > On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote:
> > > These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y.
> > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map.
> > > Thanks for the notification from Tetsuya Mukawa <mukawa@igel.co.jp>. 
> > > 
> > > Cunming Liang (2):
> > >   eal/linux: fix symbol missing in version map
> > >   eal/bsd: fix symbol missing in version map
> > > 
> > >  lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
> > >  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> > >  2 files changed, 4 insertions(+)
> > > 
> > 
> > NAK
> > 
> > This is the wrong way to fix this problem. Exporting global variables is
> > never a good solution when it can be helped.  Instead, rte_socket id should be
> > made a non inline function and exported.  Then the definition of
> > per_lcore_socket_id can be made private, protecting it from type changes.
> 
> Neil, I applied the patches to fix compilation on HEAD.
> In case your comment makes sense, a cleanup would be appreciated.
> 
> Thanks
> 
Sent. You and Cunming are CC-ed
Thanks
Neil