DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map
Date: Wed, 25 Feb 2015 09:34:38 -0500	[thread overview]
Message-ID: <20150225143438.GB31224@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1481785.S6qqJ57RgF@xps13>

On Wed, Feb 25, 2015 at 02:39:33PM +0100, Thomas Monjalon wrote:
> 2015-02-25 07:30, Neil Horman:
> > On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote:
> > > These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y.
> > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map.
> > > Thanks for the notification from Tetsuya Mukawa <mukawa@igel.co.jp>. 
> > > 
> > > Cunming Liang (2):
> > >   eal/linux: fix symbol missing in version map
> > >   eal/bsd: fix symbol missing in version map
> > > 
> > >  lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
> > >  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> > >  2 files changed, 4 insertions(+)
> > > 
> > 
> > NAK
> > 
> > This is the wrong way to fix this problem. Exporting global variables is
> > never a good solution when it can be helped.  Instead, rte_socket id should be
> > made a non inline function and exported.  Then the definition of
> > per_lcore_socket_id can be made private, protecting it from type changes.
> 
> Neil, I applied the patches to fix compilation on HEAD.
> In case your comment makes sense, a cleanup would be appreciated.
> 
> Thanks
> 
Sent. You and Cunming are CC-ed
Thanks
Neil

      reply	other threads:[~2015-02-25 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25  3:39 Cunming Liang
2015-02-25  3:39 ` [dpdk-dev] [PATCH v1 1/2] eal/linux: " Cunming Liang
2015-02-25  3:39 ` [dpdk-dev] [PATCH v1 2/2] eal/bsd: " Cunming Liang
2015-02-25  4:08 ` [dpdk-dev] [PATCH v1 0/2] eal: " Tetsuya Mukawa
2015-02-25  8:14 ` Mcnamara, John
2015-02-25  9:07   ` Thomas Monjalon
2015-02-25 12:30 ` Neil Horman
2015-02-25 13:39   ` Thomas Monjalon
2015-02-25 14:34     ` Neil Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150225143438.GB31224@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).