From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id A6E2E9A8E
 for <dev@dpdk.org>; Wed, 25 Feb 2015 15:34:48 +0100 (CET)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1YQd2s-0003xJ-T9; Wed, 25 Feb 2015 09:34:47 -0500
Date: Wed, 25 Feb 2015 09:34:38 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150225143438.GB31224@hmsreliant.think-freely.org>
References: <1424835589-18122-1-git-send-email-cunming.liang@intel.com>
 <20150225123053.GA31224@hmsreliant.think-freely.org>
 <1481785.S6qqJ57RgF@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1481785.S6qqJ57RgF@xps13>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 0/2] eal: fix symbol missing in version map
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2015 14:34:49 -0000

On Wed, Feb 25, 2015 at 02:39:33PM +0100, Thomas Monjalon wrote:
> 2015-02-25 07:30, Neil Horman:
> > On Wed, Feb 25, 2015 at 11:39:47AM +0800, Cunming Liang wrote:
> > > These two patches are the fixing for the compling error when CONFIG_RTE_BUILD_SHARED_LIB=y.
> > > The root cause is *per_lcore__socket_id* and *rte_sys_gettid* are missing in the version map.
> > > Thanks for the notification from Tetsuya Mukawa <mukawa@igel.co.jp>. 
> > > 
> > > Cunming Liang (2):
> > >   eal/linux: fix symbol missing in version map
> > >   eal/bsd: fix symbol missing in version map
> > > 
> > >  lib/librte_eal/bsdapp/eal/rte_eal_version.map   | 2 ++
> > >  lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++
> > >  2 files changed, 4 insertions(+)
> > > 
> > 
> > NAK
> > 
> > This is the wrong way to fix this problem. Exporting global variables is
> > never a good solution when it can be helped.  Instead, rte_socket id should be
> > made a non inline function and exported.  Then the definition of
> > per_lcore_socket_id can be made private, protecting it from type changes.
> 
> Neil, I applied the patches to fix compilation on HEAD.
> In case your comment makes sense, a cleanup would be appreciated.
> 
> Thanks
> 
Sent. You and Cunming are CC-ed
Thanks
Neil