From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id 5F6AE5680 for ; Thu, 26 Feb 2015 14:49:12 +0100 (CET) Received: by wevm14 with SMTP id m14so10814538wev.13 for ; Thu, 26 Feb 2015 05:49:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to; bh=1KXrf3EIwWhr/FjilgBoWEs/6pXsuyYs5N/MmSiYrBU=; b=lp67PXL4jNTRslN2y01kOpyM2RusGpgo97UpyBsJ54imApyyTnZpszRGz1heIQTXJk Ucun2W/WoAr78XM26ab8yi5ulNnuE1X4X+GLLjQRI/VzMLlPDNei3jl9JMVxxXzDJdPw ZE1X49BKmb2W39UNNO2SDF6WagFUVDs13e/VQQrmuTpLgA3XCP0/TfryPg/wzHUwb10E Bkv5SUmTPLpSeaZjATfbJ9dghn3ULHG1WOel1M/LmCnYA9MU+davVVvc1gO+dVK0Tiyb EZ/pFG99aLLT856K07NLZ49DCc4xOqAtNfv3S/sj7nAs/7nirYCWIBzJAVJaFpoTVvG3 7DFA== X-Gm-Message-State: ALoCoQk/r90ysJes79zz7Zn8ZBXRCjqrhrOXdtKrmFpaOR0Q9xgCm3XO3s1xlAnLOJbC8zRPOfPV X-Received: by 10.194.81.104 with SMTP id z8mr16592669wjx.45.1424958552171; Thu, 26 Feb 2015 05:49:12 -0800 (PST) Received: from trex.cloudius-systems.com ([212.143.139.214]) by mx.google.com with ESMTPSA id dn1sm2920881wid.11.2015.02.26.05.49.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2015 05:49:11 -0800 (PST) Received: by trex.cloudius-systems.com (Postfix, from userid 1042) id E2F6683EC2; Thu, 26 Feb 2015 15:49:07 +0200 (IST) Date: Thu, 26 Feb 2015 15:49:07 +0200 From: Gleb Natapov To: Thomas Monjalon Message-ID: <20150226134907.GV3806@cloudius-systems.com> References: <1424492174-27072-1-git-send-email-adrien.mazarguil@6wind.com> <1424872326-17930-1-git-send-email-adrien.mazarguil@6wind.com> <20150226115137.GU3806@cloudius-systems.com> <7873324.ABPKluIWcB@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=cp1255 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <7873324.ABPKluIWcB@xps13> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2015 13:49:12 -0000 On Thu, Feb 26, 2015 at 02:36:27PM +0100, Thomas Monjalon wrote: > 2015-02-26 13:51, Gleb Natapov: > > Did git pull today. After enabling mlnx pmd compilation fails with: > >=20 > > dpdk/lib/librte_pmd_mlx4/mlx4.c: In function =91mlx4_pci_devinit=92: > > dpdk/lib/librte_pmd_mlx4/mlx4.c:4636:14: error: too few arguments to fu= nction =91rte_eth_dev_allocate=92 > > eth_dev =3D rte_eth_dev_allocate(name); >=20 > Yes, thanks for reporting. > I didn't test the disabled mlx4 after hotplug integration: > dpdk.org/browse/dpdk/commit/?id=3D9f1653e7b7e1746e7c >=20 > Clearly, I have to improve my sanity checks. > Sorry for the inconvenience. No problem, I fixed that locally, but now I see another issue. I have several PMDs statically compiled in with my application and I expect dpdk to choose correct one depending on available HW, but mlnx pmd does not behave nicely, if its initialization fails it kills entire application: EAL: PCI device 0000:03:00.0 on NUMA socket 0 EAL: probe driver: 15b3:1003 librte_pmd_mlx4 EAL: Error - exiting with code: 1 Cause: Requested device 0000:03:00.0 cannot be used This is how other pmds handle situation when init cannot be done: EAL: PCI device 0000:02:00.0 on NUMA socket 0 EAL: probe driver: 8086:1528 rte_ixgbe_pmd EAL: Not managed by known pt driver, skipped EAL: PCI device 0000:02:00.1 on NUMA socket 0 EAL: probe driver: 8086:1528 rte_ixgbe_pmd EAL: Not managed by known pt driver, skipped -- Gleb.