From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gleb@cloudius-systems.com>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 2585F5697
 for <dev@dpdk.org>; Thu, 26 Feb 2015 16:03:43 +0100 (CET)
Received: by wggy19 with SMTP id y19so11599420wgg.10
 for <dev@dpdk.org>; Thu, 26 Feb 2015 07:03:43 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:subject:message-id:references
 :mime-version:content-type:content-disposition
 :content-transfer-encoding:in-reply-to;
 bh=74yPzSNH/KQojI3t4dCt119UfY9gMbHSXxBI6RvANIo=;
 b=K7O9aqnRVr73drWfbH3O681mS9WDJzrqzFdZ3rPxEkt7Awf3r6WQEs2q7k5hv4rivd
 t3FEuMLoQ/WVuU4OQ5pkZ6iZQSWd/CWtPWul2gq6l0zqQ8ltQb92ri8rM9qel6fL+9Vu
 IRxnm/jovQO+C1TDq2zQTXK0Jbg5IqGdLTCthkL7uQokHoyEi2WwmJSfpKqVr4zsgV23
 RRN/rToyBm4xXVXADIpgaah+4Uu/sDBYD9uHw1jU93ZUWraceJj1vDp5wZCINbqD/ctQ
 qZiJJ7amjqDm7I+fQ2CO4o6EVr8PQzlpHTvDzzMPQGXIuFUs3FIwJXn5bsySx5+9fvxQ
 /DaA==
X-Gm-Message-State: ALoCoQniXbjucms+filwBQQatpcJbTD7sxZRkewUINMEAUqPZGEoarWaNBacAyHeoniK7Z+vfvjS
X-Received: by 10.194.175.39 with SMTP id bx7mr18161458wjc.22.1424963022815;
 Thu, 26 Feb 2015 07:03:42 -0800 (PST)
Received: from trex.cloudius-systems.com
 (bzq-84-111-155-225.cablep.bezeqint.net. [84.111.155.225])
 by mx.google.com with ESMTPSA id gi9sm30222862wib.21.2015.02.26.07.03.41
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 26 Feb 2015 07:03:42 -0800 (PST)
Received: by trex.cloudius-systems.com (Postfix, from userid 1042)
 id 1A26383EC2; Thu, 26 Feb 2015 17:03:34 +0200 (IST)
Date: Thu, 26 Feb 2015 17:03:34 +0200
From: Gleb Natapov <gleb@cloudius-systems.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Message-ID: <20150226150334.GA23946@cloudius-systems.com>
References: <1424492174-27072-1-git-send-email-adrien.mazarguil@6wind.com>
 <1424872326-17930-1-git-send-email-adrien.mazarguil@6wind.com>
 <20150226115137.GU3806@cloudius-systems.com>
 <7873324.ABPKluIWcB@xps13>
 <20150226134907.GV3806@cloudius-systems.com>
 <20150226141834.GX23569@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=cp1255
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20150226141834.GX23569@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Feb 2015 15:03:43 -0000

On Thu, Feb 26, 2015 at 03:18:34PM +0100, Adrien Mazarguil wrote:
> On Thu, Feb 26, 2015 at 03:49:07PM +0200, Gleb Natapov wrote:
> > On Thu, Feb 26, 2015 at 02:36:27PM +0100, Thomas Monjalon wrote:
> > > 2015-02-26 13:51, Gleb Natapov:
> > > > Did git pull today. After enabling mlnx pmd compilation fails with:
> > > >=20
> > > > dpdk/lib/librte_pmd_mlx4/mlx4.c: In function =91mlx4_pci_devinit=92:
> > > > dpdk/lib/librte_pmd_mlx4/mlx4.c:4636:14: error: too few arguments t=
o function =91rte_eth_dev_allocate=92
> > > >     eth_dev =3D rte_eth_dev_allocate(name);
> > >=20
> > > Yes, thanks for reporting.
> > > I didn't test the disabled mlx4 after hotplug integration:
> > > 	dpdk.org/browse/dpdk/commit/?id=3D9f1653e7b7e1746e7c
> > >=20
> > > Clearly, I have to improve my sanity checks.
> > > Sorry for the inconvenience.
> > No problem, I fixed that locally, but now I see another issue. I have
> > several PMDs statically compiled in with my application and I expect
> > dpdk to choose correct one depending on available HW, but mlnx pmd does
> > not behave nicely, if its initialization fails it kills entire
> > application:
> >=20
> > EAL: PCI device 0000:03:00.0 on NUMA socket 0
> > EAL:   probe driver: 15b3:1003 librte_pmd_mlx4
> > EAL: Error - exiting with code: 1
> >   Cause: Requested device 0000:03:00.0 cannot be used
>=20
> About this error, make sure you are using the kernel modules provided by =
the
> mlnx-ofed-kernel package from MOFED [1] as described in the documentation.
>=20
The problem is not in the error, I know how to get rid of it, but in the
error handling. My program has a fallback, so I an error to init a PMD
should not kill it, non other PMDs do.

--
			Gleb.