From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 06CEA234 for ; Sun, 1 Mar 2015 12:07:44 +0100 (CET) Received: by wiwh11 with SMTP id h11so8865778wiw.1 for ; Sun, 01 Mar 2015 03:07:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to; bh=nR9OUuhA1docuVxpivtUrZvmiLhAHNElfvSXc0BeyUI=; b=SdDn5NgsLz9zZ1ENDnyq6fCU+S6Z+S9r/8G44EuaKD0UFPrSMHUqfj9JX3fDdx1lm2 WCJrV9xWmU+pvSaQeYRCMcXVcRHc9Ky/54el2Tw66Bgz7hsdU+UgGkSMTEpr0xO3E8y8 rNG174kD4EqCDG9ObjUFM0bz2NB578ZHwSGoAHB8IHNY4V533DaX8GLPhAAijt04nUjZ xNtczky+BUWWLvkdNtjrd+aXf7ia9eoB1nIs6coIpYv9023BOHvSq3O3itSsMX7BlA98 K9Hs4eVjStKr8Z69bipdNbIiPgyO7WPreE++K2h0s3aYdoBT0KPPlVHiPhKvOiiCFnHG eELg== X-Gm-Message-State: ALoCoQlUX86CIvDPE1JOCAkRiTylnjfWHDxCheYWN3Z4RS+YK2L9rs85E8h8Gi9AnzwJJjuVmoWv X-Received: by 10.180.19.9 with SMTP id a9mr25101914wie.85.1425208063821; Sun, 01 Mar 2015 03:07:43 -0800 (PST) Received: from trex.cloudius-systems.com ([212.143.139.214]) by mx.google.com with ESMTPSA id fu1sm11058781wic.2.2015.03.01.03.07.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Mar 2015 03:07:42 -0800 (PST) Received: by trex.cloudius-systems.com (Postfix, from userid 1042) id E7A9283EC1; Sun, 1 Mar 2015 13:07:40 +0200 (IST) Date: Sun, 1 Mar 2015 13:07:40 +0200 From: Gleb Natapov To: Thomas Monjalon , dev@dpdk.org Message-ID: <20150301110740.GX3806@cloudius-systems.com> References: <1424492174-27072-1-git-send-email-adrien.mazarguil@6wind.com> <1424872326-17930-1-git-send-email-adrien.mazarguil@6wind.com> <20150226115137.GU3806@cloudius-systems.com> <7873324.ABPKluIWcB@xps13> <20150226134907.GV3806@cloudius-systems.com> <20150227183859.GD23569@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=cp1255 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20150227183859.GD23569@6wind.com> Subject: Re: [dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2015 11:07:44 -0000 On Fri, Feb 27, 2015 at 07:38:59PM +0100, Adrien Mazarguil wrote: > On Thu, Feb 26, 2015 at 03:49:07PM +0200, Gleb Natapov wrote: > > On Thu, Feb 26, 2015 at 02:36:27PM +0100, Thomas Monjalon wrote: > > > 2015-02-26 13:51, Gleb Natapov: > > > > Did git pull today. After enabling mlnx pmd compilation fails with: > > > >=20 > > > > dpdk/lib/librte_pmd_mlx4/mlx4.c: In function =91mlx4_pci_devinit=92: > > > > dpdk/lib/librte_pmd_mlx4/mlx4.c:4636:14: error: too few arguments t= o function =91rte_eth_dev_allocate=92 > > > > eth_dev =3D rte_eth_dev_allocate(name); > > >=20 > > > Yes, thanks for reporting. > > > I didn't test the disabled mlx4 after hotplug integration: > > > dpdk.org/browse/dpdk/commit/?id=3D9f1653e7b7e1746e7c > > >=20 > > > Clearly, I have to improve my sanity checks. > > > Sorry for the inconvenience. > > No problem, I fixed that locally, but now I see another issue. I have > > several PMDs statically compiled in with my application and I expect > > dpdk to choose correct one depending on available HW, but mlnx pmd does > > not behave nicely, if its initialization fails it kills entire > > application: > >=20 > > EAL: PCI device 0000:03:00.0 on NUMA socket 0 > > EAL: probe driver: 15b3:1003 librte_pmd_mlx4 > > EAL: Error - exiting with code: 1 > > Cause: Requested device 0000:03:00.0 cannot be used >=20 > Forgot to set in-reply-to, but I just sent a patch to work around that > issue and make mlx4 nicer: >=20 > http://dpdk.org/dev/patchwork/patch/3796/ >=20 Works for me, thanks! May be better to change: "cannot use device, are drivers up to date? To "cannot use device, are drivers and fw up to date?". On one of my machines that was the case. I see that some features are missing from the PMD though. Some of them are nice to have for good performance like providing rss hash value in mbuf (PKT_RX_RSS_HASH), but others are absolutely required for my application to work: setting (or at least getting) rss key and redirection table. Are there any plans to support those? -- Gleb.