From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 587275A73 for ; Tue, 3 Mar 2015 14:33:05 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 03 Mar 2015 05:33:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,681,1418112000"; d="scan'208";a="693263678" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.27]) by orsmga002.jf.intel.com with SMTP; 03 Mar 2015 05:32:54 -0800 Received: by (sSMTP sendmail emulation); Tue, 03 Mar 2015 13:32:46 +0025 Date: Tue, 3 Mar 2015 13:32:46 +0000 From: Bruce Richardson To: Raz Amir Message-ID: <20150303133246.GB11084@bricha3-MOBL3> References: <1424932400-66862-1-git-send-email-razamir22@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424932400-66862-1-git-send-email-razamir22@gmail.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pci: save list of detached devices, and re-probe during driver unload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2015 13:33:05 -0000 On Thu, Feb 26, 2015 at 06:33:20AM +0000, Raz Amir wrote: > Added code that saves the pointers to the detached devices, during > driver loading, and during driver unloading, go over the list, > and re-attach them by calling device_probe_and_attach > on each device. > > Signed-off-by: Raz Amir Couple of minor comments below. Otherwise all looks good to me. Acked-by: Bruce Richardson > --- > lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > index 5ae8560..7d702a5 100644 > --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$"); > > #define MAX_BARS (PCIR_MAX_BAR_0 + 1) > > +#define MAX_DETACHED_DEVICES 128 > +static device_t detached_devices[MAX_DETACHED_DEVICES] = {}; > +static int last_detached = 0; Maybe num_detached/nb_detached or even just "detached" instead of "last_detached". > > struct nic_uio_softc { > device_t dev_t; > @@ -291,14 +294,35 @@ nic_uio_load(void) > if (dev != NULL) We are getting into some serious levels of indentation below, so maybe flip this condition around and put in a "continue" instead, so that we can dedent everything below that follows it. > for (i = 0; i < NUM_DEVICES; i++) > if (pci_get_vendor(dev) == devices[i].vend && > - pci_get_device(dev) == devices[i].dev) > + pci_get_device(dev) == devices[i].dev) { > + if (last_detached+1 < MAX_DETACHED_DEVICES) { I don't think you need the +1 here. > + printf("nic_uio_load: detaching and storing dev=%p\n", dev); > + detached_devices[last_detached++] = dev; > + } > + else { > + printf("nic_uio_load: reached MAX_DETACHED_DEVICES=%d. dev=%p won't be reattached\n", > + MAX_DETACHED_DEVICES, dev); > + } DPDK coding style is not to put braces around single-line statements like this. > + Remove whitespace from this new line. > device_detach(dev); > + } > } > } > > static void > nic_uio_unload(void) > { > + int i; > + printf("nic_uio_unload: entered ... \n"); > + > + for (i = 0; i < last_detached; i++) { > + printf("nic_uio_unload: calling to device_probe_and_attach for dev=%p...\n", > + detached_devices[i]); > + device_probe_and_attach(detached_devices[i]); > + printf("nic_uio_unload: done.\n"); > + } > + > + printf("nic_uio_unload: leaving ... \n"); > } > > static int > -- > 2.1.2 >