From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <adrien.mazarguil@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
by dpdk.org (Postfix) with ESMTP id 8D6CE5A83
for <dev@dpdk.org>; Tue, 3 Mar 2015 17:02:59 +0100 (CET)
Received: by wggx12 with SMTP id x12so40952534wgg.6
for <dev@dpdk.org>; Tue, 03 Mar 2015 08:02:59 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:date:from:to:cc:subject:message-id
:mail-followup-to:references:mime-version:content-type
:content-disposition:in-reply-to;
bh=wtrNjX+hkT8sP+XKXHrFEaCswsWpV0aZ/UfiSutIrSk=;
b=hnu9X+TY+vPQcbyYsQYQejc/03h12C1idsnoMjR/5FolNcVDClLqTRR63YG3htpwK8
k2vCCDjUz34eww6lsqMJQPNBiev1/fdKB4pn94Ynd8TgaZIoanwh6wcvTm5cS59clJtl
uQtMq3u1Sdo9on1I14dS22sMKsHphQjX+4DBTnAqEEAFPn1QNehPxKAXD/W5kUaiQdzG
gdPDorAGs4G1KIwzQIgSzJV4jZ+/mqyMLWUxI0zbFAbqBrKCOdi7Rj/rCZMWvL8Xx0vI
JawFh3EFqZ8cU9miJWPYGJ9uocP7ya8GhkCDT+JX9yxYItCcSlUIf5BlF/1S8auRQkZf
XJ5g==
X-Gm-Message-State: ALoCoQkPaXwt/5+OKUr9FhxJFlKksct+m7oOHnAz778Cy4CXQ08smcAHe6U+INLWl1la+1yYJl0g
X-Received: by 10.180.75.243 with SMTP id f19mr4137735wiw.94.1425398579278;
Tue, 03 Mar 2015 08:02:59 -0800 (PST)
Received: from 6wind.com (6wind.net2.nerim.net. [213.41.180.237])
by mx.google.com with ESMTPSA id lg18sm233822wic.23.2015.03.03.08.02.57
(version=TLSv1 cipher=RC4-SHA bits=128/128);
Tue, 03 Mar 2015 08:02:58 -0800 (PST)
Date: Tue, 3 Mar 2015 17:02:58 +0100
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150303160258.GJ23569@6wind.com>
Mail-Followup-To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
References: <1425396230-13379-1-git-send-email-thomas.monjalon@6wind.com>
<1425396230-13379-6-git-send-email-thomas.monjalon@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1425396230-13379-6-git-send-email-thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/7] mlx4: fix build with mempool debug
enabled
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Mar 2015 16:02:59 -0000
On Tue, Mar 03, 2015 at 04:23:48PM +0100, Thomas Monjalon wrote:
> The mempool header forces error on -Wcast-qual and makes verbs.h failing.
> Let's include verbs before as a system header.
>
> Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> lib/librte_pmd_mlx4/mlx4.c | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/lib/librte_pmd_mlx4/mlx4.c b/lib/librte_pmd_mlx4/mlx4.c
> index 492cbbf..b5774c4 100644
> --- a/lib/librte_pmd_mlx4/mlx4.c
> +++ b/lib/librte_pmd_mlx4/mlx4.c
> @@ -60,6 +60,16 @@
> #include <linux/ethtool.h>
> #include <linux/sockios.h>
>
> +/* Verbs header. */
> +/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */
> +#ifdef PEDANTIC
> +#pragma GCC diagnostic ignored "-pedantic"
> +#endif
> +#include <infiniband/verbs.h>
> +#ifdef PEDANTIC
> +#pragma GCC diagnostic error "-pedantic"
> +#endif
> +
> /* DPDK headers don't like -pedantic. */
> #ifdef PEDANTIC
> #pragma GCC diagnostic ignored "-pedantic"
> @@ -81,18 +91,6 @@
> #pragma GCC diagnostic error "-pedantic"
> #endif
>
> -/* Verbs header. */
> -/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */
> -#ifdef PEDANTIC
> -#pragma GCC diagnostic ignored "-pedantic"
> -#endif
> -
> -#include <infiniband/verbs.h>
> -
> -#ifdef PEDANTIC
> -#pragma GCC diagnostic error "-pedantic"
> -#endif
> -
> /* Generated configuration header. */
> #include "mlx4_autoconf.h"
>
> --
> 2.2.2
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND