From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f182.google.com (mail-ig0-f182.google.com [209.85.213.182]) by dpdk.org (Postfix) with ESMTP id 47E01568F for ; Wed, 4 Mar 2015 01:36:36 +0100 (CET) Received: by igbhl2 with SMTP id hl2so32819588igb.3 for ; Tue, 03 Mar 2015 16:36:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=EtGHulfJuM7WJTYtTW/4dU2xaEThuGmaDP4muqixv5Q=; b=NQdjTo3HGgYhAUi7kt6t/nPyOeon1wCK0g9X7MFKU23b/lXgweQ2qQNdrnrm2KH42M uaNfmLAVc/XxWLER/Jd4bzyWm9Ki8xNC3SOjUhodBkLTTRXld/M8sXIIE/LU1YZH2dHc 1EBdQdBJ/vA5dx//8DCsnKIFkuezheml2vgK1Cd3UkO7oWEEZZtA3/5RHRKtOIYRh4rK bmbPIEt3xwxZqr2H/nphWE5X05lIhCBhA6D6ws9NGwtslXNgPc6LZshwVniPLtz5oO8i QXF4IlKQaOAMfW/mcbNOAJwqt1R6nRnLNDGFF1WXw3aIuIwW7Kndk/diWeINc2Fj3PEe Iglw== X-Gm-Message-State: ALoCoQmw5JcWkx+mKxAY+xczc7ZaOSEAG8ZlcDFqTKtO+fL+Y2qiuEYw6sWLn901uw8MxUTl/0cQ X-Received: by 10.50.49.43 with SMTP id r11mr33526022ign.18.1425429395726; Tue, 03 Mar 2015 16:36:35 -0800 (PST) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id vk4sm1948649igc.11.2015.03.03.16.36.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Mar 2015 16:36:35 -0800 (PST) Date: Tue, 3 Mar 2015 16:36:38 -0800 From: Stephen Hemminger To: Vlad Zolotarov Message-ID: <20150303163638.118d630e@urahara> In-Reply-To: <1425412123-5227-6-git-send-email-vladz@cloudius-systems.com> References: <1425412123-5227-1-git-send-email-vladz@cloudius-systems.com> <1425412123-5227-6-git-send-email-vladz@cloudius-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 00:36:36 -0000 On Tue, 3 Mar 2015 21:48:43 +0200 Vlad Zolotarov wrote: > - Only x540 and 82599 devices support LRO. > - Add the appropriate HW configuration. > - Add RSC aware rx_pkt_burst() handlers: > - Implemented bulk allocation and non-bulk allocation versions. > - Add LRO-specific fields to rte_eth_rxmode, to rte_eth_dev_data > and to igb_rx_queue. > - Use the appropriate handler when LRO is requested. > > Signed-off-by: Vlad Zolotarov Checkpatch warnings (edited to remove ones that should be ok) WARNING: 'recieved' may be misspelled - perhaps 'received'? #196: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1426: + * @rx_pkts table of recieved packets WARNING: Missing a blank line after declarations #223: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1453: + struct igb_rx_queue *rxq = rx_queue; + volatile union ixgbe_adv_rx_desc *rx_ring = rxq->rx_ring; WARNING: labels should not be indented #246: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1476: + next_desc: WARNING: quoted string split across lines #285: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1515: + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_id=%u " + "staterr=0x%x data_len=%u", WARNING: quoted string split across lines #293: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1523: + PMD_RX_LOG(DEBUG, "RX mbuf alloc failed " + "port_id=%u queue_id=%u", WARNING: Missing a blank line after declarations #302: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1532: + uint16_t next_rdt = rxq->rx_free_trigger; + if (!ixgbe_rx_alloc_bufs(rxq, false)) { WARNING: quoted string split across lines #309: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1539: + PMD_RX_LOG(DEBUG, "RX bulk alloc failed " + "port_id=%u queue_id=%u", ERROR: code indent should use tabs where possible #350: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1580: + rxm->data_off = RTE_PKTMBUF_HEADROOM;$ WARNING: please, no spaces at the start of a line #350: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1580: + rxm->data_off = RTE_PKTMBUF_HEADROOM;$ WARNING: quoted string split across lines #452: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1682: + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_tail=%u " + "nb_hold=%u nb_rx=%u", WARNING: quoted string split across lines #536: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2580: + PMD_INIT_LOG(DEBUG, "sw_ring=%p sw_rsc_ring=%p hw_ring=%p " + "dma_addr=0x%"PRIx64, WARNING: Possible switch case/default not preceeded by break or fallthrough comment #617: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3926: + default: WARNING: quoted string split across lines #648: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3966: + PMD_INIT_LOG(CRIT, "LRO is requested on HW that doesn't " + "support it"); WARNING: quoted string split across lines #693: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4022: + PMD_INIT_LOG(CRIT, "LRO can't be enabled when HW CRC " + "is disabled"); WARNING: quoted string split across lines #711: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4084: + PMD_INIT_LOG(INFO, "split_hdr_size less than " + "128 bytes (%d)!", WARNING: quoted string split across lines #835: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4267: + PMD_INIT_LOG(INFO, "LRO is requested. Using a bulk " + "allocation version"); WARNING: quoted string split across lines #840: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4272: + PMD_INIT_LOG(INFO, "LRO is requested. Using a single " + "allocation version");