From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ie0-f175.google.com (mail-ie0-f175.google.com
 [209.85.223.175]) by dpdk.org (Postfix) with ESMTP id C42195A7A
 for <dev@dpdk.org>; Wed,  4 Mar 2015 19:51:51 +0100 (CET)
Received: by iecrp18 with SMTP id rp18so1877015iec.10
 for <dev@dpdk.org>; Wed, 04 Mar 2015 10:51:51 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=UvGAisckZfXGecgr1HHyHbV9TnybX5cHIuflQMWUPA0=;
 b=B0QqPRZYfrqYeIrHR0k51eQgZnYPD6yvKE78QwHEVsskc8j6WExrVVf/CJdXSNK3Se
 kD0eonT9uupDUGMQI5Sv6wpJ0920AOTBzEuatvF3kNvRjhybm2DkRIQJ5boalTwowmBK
 3waTbc0SuDBckTai1/5+WnUcGV3Le90xYD5blxwOUnQlJDKmlfFQthw0tHkrKN78u12P
 dBfF8ZJUJT71xn3RcIcUuNERQsbj2Yl8j8E3Dnp29xAFWwHcloP2EWp/4PfUOYP5UNin
 lHnPdEf/Tyyghmz7kZg7KsxuAA0M+oAEQiE6iuDZD4tH1Qjg5Kha+qaw/TtbljKx3Tdo
 H1HQ==
X-Gm-Message-State: ALoCoQnDDGCuzY+BLezyd+kcKtZQ66Cqu2iWoCHoYyYNV7OulaNlV7zNtNwIhUXx3HW/9kAOdm0X
X-Received: by 10.50.62.83 with SMTP id w19mr13895659igr.26.1425495111124;
 Wed, 04 Mar 2015 10:51:51 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id s17sm11208006igr.2.2015.03.04.10.51.50
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 04 Mar 2015 10:51:50 -0800 (PST)
Date: Wed, 4 Mar 2015 10:51:51 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vlad Zolotarov <vladz@cloudius-systems.com>
Message-ID: <20150304105151.0a6f0553@urahara>
In-Reply-To: <54F6BB6A.5080205@cloudius-systems.com>
References: <1425412123-5227-1-git-send-email-vladz@cloudius-systems.com>
 <1425412123-5227-6-git-send-email-vladz@cloudius-systems.com>
 <20150303163638.118d630e@urahara>
 <54F6BB6A.5080205@cloudius-systems.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2015 18:51:52 -0000

On Wed, 04 Mar 2015 09:59:38 +0200
Vlad Zolotarov <vladz@cloudius-systems.com> wrote:

> > Checkpatch warnings (edited to remove ones that should be ok)  
> 
> I was unaware that checkpatch rules apply here - at least looking at the 
> current code it looks like it... ;)
> But I'm all for it! I'll fix all the issues and respin

Checkpatch doesn't generally have to apply. But is good and useful tool
to find obvious style gaffs.

Just don't let it rule your world