From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com
 [209.85.223.174]) by dpdk.org (Postfix) with ESMTP id 23DE05A74
 for <dev@dpdk.org>; Thu,  5 Mar 2015 00:06:41 +0100 (CET)
Received: by iecar1 with SMTP id ar1so71697268iec.11
 for <dev@dpdk.org>; Wed, 04 Mar 2015 15:06:40 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=KIHpxiNrm7GGgVEXYnATM/kR8zvu8hq+L6sjbnfc9wI=;
 b=F8tG46EfQ4Iia8LsWqhKicthka8F0VXsjPNl14Em9CKvtj4QjJzsedGx85wvQyn7l+
 mHteyVAGcYRDb3+RZxMPJ02il5Iq1Zfd7mtKyJPXot+17rhYEmq1vB9ZYP1Uz3zZdL9c
 F5yY4IuNPghz9/6LZE+I2yA6nO0ssqAlRrDSW+gbOD1o8D4ffbWheUqWgAqVQZz3wswb
 aZ4j1oK0w3zOPmgUO1l5+YqVpL97KnauoOftP4WCtSOmGgWh3qmNE3oL0qFAkU7YxDdN
 9o0b+ysELAkydhqEZG9EgA1owlG6YDIJZWaPIBC94XwFqYaB0/kn800xkSW+L10VRR/D
 hDjQ==
X-Gm-Message-State: ALoCoQnGqR1pYKcYvJKupB2u/kyb1a2h/d313mt41f5aLu0ZKSASxx2IC4nu3+NmXMfaHJaGvy7z
X-Received: by 10.50.73.99 with SMTP id k3mr42292257igv.21.1425510400511;
 Wed, 04 Mar 2015 15:06:40 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id r78sm3767620ioi.22.2015.03.04.15.06.39
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 04 Mar 2015 15:06:40 -0800 (PST)
Date: Wed, 4 Mar 2015 15:06:41 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150304150641.1462cce6@urahara>
In-Reply-To: <9265c0d3b03e4f33b7823139be7b3b91@BRMWP-EXMB11.corp.brocade.com>
References: <1421994224-2127-1-git-send-email-stephen@networkplumber.org>
 <7916082.1WV7FdSlI3@xps13> <20150127113847.3d4d32a0@uryu.home.lan>
 <9265c0d3b03e4f33b7823139be7b3b91@BRMWP-EXMB11.corp.brocade.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@Brocade.com>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2015 23:06:41 -0000

On Wed, 4 Mar 2015 20:55:05 +0000
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> Anyone to carefully review this patch?
> 
> 2015-01-27 11:38, Stephen Hemminger:
> > On Tue, 27 Jan 2015 11:11:39 +0100
> > Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> >   
> > > Hi Stephen,
> > > 
> > > 2015-01-22 22:23, stephen@networkplumber.org:  
> > > > From: Stephen Hemminger <shemming@brocade.com>
> > > > 
> > > > The ixgbe driver was including CRC in the transmit packet byte
> > > > count, but not for packets received. This was notice when forwarding and
> > > > the number of bytes received was greater than the number of bytes transmitted  
> > > 
> > > Tx includes CRC and Rx count is greater, really?  

Yes. This is observable fact.
The gotc register includes CRC and the per-queue register do not.