From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id D9DB05677
 for <dev@dpdk.org>; Fri,  6 Mar 2015 12:10:29 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 06 Mar 2015 03:08:57 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,352,1422950400"; d="scan'208";a="537014182"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.21])
 by orsmga003.jf.intel.com with SMTP; 06 Mar 2015 03:10:12 -0800
Received: by  (sSMTP sendmail emulation); Fri, 06 Mar 2015 11:10:26 +0025
Date: Fri, 6 Mar 2015 11:10:26 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tomas Vestelind <tomas.vestelind@gmail.com>
Message-ID: <20150306111025.GA9352@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] hash: added rte_hash_clear that clears all
 keys
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Mar 2015 11:10:30 -0000

On Tue, Aug 12, 2014 at 11:47:57PM +0200, Tomas Vestelind wrote:
> I added rte_hash_clear which clear the map from all previously added
> keys.
> 
This patch is now quite old and needs an update to add the new API to the
rte_hash_version.map. A unit test for the new function would also be good to
have. Otherwise patch content looks ok. Is an updated V2 planned?

Regards,
/Bruce

> Signed-off-by: Tomas Vestelind <tomas.vestelind at gmail.com>
> ---
>  lib/librte_hash/rte_hash.c |   14 ++++++++++++++
>  lib/librte_hash/rte_hash.h |   10 ++++++++++
>  2 files changed, 24 insertions(+)
> 
> diff --git a/lib/librte_hash/rte_hash.c b/lib/librte_hash/rte_hash.c
> index 2108c4f..917a6c1 100644
> --- a/lib/librte_hash/rte_hash.c
> +++ b/lib/librte_hash/rte_hash.c
> @@ -507,3 +507,17 @@ rte_hash_keys(const struct rte_hash *h, void *keys)
>  
>      return found_keys;
>  }
> +
> +void
> +rte_hash_clear(const struct rte_hash *h)
> +{
> +    unsigned int bucket, entry;
> +
> +    /* Clear all entries by invalidating each signature */
> +    for (bucket = 0; bucket < h->num_buckets; bucket++) {
> +        hash_sig_t *sig = get_sig_tbl_bucket(h, bucket);
> +        for (entry = 0; entry < h->bucket_entries; entry++) {
> +            sig[entry] = NULL_SIGNATURE;
> +        }
> +    }
> +}
> diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
> index e0fb28f..b84137e 100644
> --- a/lib/librte_hash/rte_hash.h
> +++ b/lib/librte_hash/rte_hash.h
> @@ -318,6 +318,16 @@ rte_hash_lookup_bulk(const struct rte_hash *h, const void **keys,
>   */
>  unsigned int
>  rte_hash_keys(const struct rte_hash *h, void *keys);
> +
> +/**
> + * Clear all keys. This operation is not multi-thread safe and should only be
> + * called from one thread.
> + *
> + * @param h
> + *   Hash table to clear.
> + */
> +void
> +rte_hash_clear(const struct rte_hash *h);
>  #ifdef __cplusplus
>  }
>  #endif
> -- 
> 1.7.10.4
>