From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com
 [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 03FC65A98
 for <dev@dpdk.org>; Sat,  7 Mar 2015 03:00:26 +0100 (CET)
Received: by pdev10 with SMTP id v10so32957388pde.0
 for <dev@dpdk.org>; Fri, 06 Mar 2015 18:00:25 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=r5LgGD1KbeWy7NvEMUT10Za9O+hukq7AbRoCwU0WTqE=;
 b=UU2yKZIpFBh1664/UsB5X4H+H5keD3IwF7M6JsBgDYmep/kfs5LsRzIMW71U2VKaoP
 W1vthCjKzSKPgPCmMLASTjLtpbf0ArMLHq1Wfww9VLWvW900iZyAZfDAJMFlMJN9nkRl
 gPTp1ibzhA1kPPLFcji5sXCx0uY9gVQcl6NZs/nmt0wLYHT419RTpwSKzwpnrrGSuaZa
 jVhKSS10Se7Y13uvOVxfWqarwXHAgGAfOP9Ozdjp83zZsdiNDgzj/j62Pql0CpcEfMzi
 UpnmQhvGME6EmBa8NC4+D0HY7J7DKw5IG84JdJh+MD5h62HqvKxocYn6ObXms54LjDbj
 8qGA==
X-Gm-Message-State: ALoCoQnu61C0YPoB/9hm1r1ydbjh6ylATzg7gy33HTikGfH+HqPJALKiYDcsFyhlRyt3volswNN+
X-Received: by 10.70.129.43 with SMTP id nt11mr30716557pdb.79.1425693625196;
 Fri, 06 Mar 2015 18:00:25 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id xx7sm10787001pab.21.2015.03.06.18.00.24
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 06 Mar 2015 18:00:24 -0800 (PST)
Date: Fri, 6 Mar 2015 18:00:21 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yong Wang <yongwang@vmware.com>
Message-ID: <20150306180021.2129c1f6@urahara>
In-Reply-To: <D11F7D7A.389BD%yongwang@vmware.com>
References: <1425600635-20628-1-git-send-email-stephen@networkplumber.org>
 <1425600635-20628-11-git-send-email-stephen@networkplumber.org>
 <D11F7D7A.389BD%yongwang@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH v3 10/10] vmxnet3: remove excess inlining
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Mar 2015 02:00:26 -0000

On Fri, 6 Mar 2015 23:54:23 +0000
Yong Wang <yongwang@vmware.com> wrote:

> Since there is only one caller of this routine, inlining it should be
> fine. But I have no problem with letting the compiler decide (which
> probably will inline it anyway for this particular case).

Sometimes compiler will not inline because of register pressure issues
especially on 32 bit where there aren't enough registers.