From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E64515ABA for ; Mon, 9 Mar 2015 14:31:47 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 09 Mar 2015 06:31:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,367,1422950400"; d="scan'208";a="677293421" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.26]) by fmsmga001.fm.intel.com with SMTP; 09 Mar 2015 06:31:45 -0700 Received: by (sSMTP sendmail emulation); Mon, 09 Mar 2015 13:31:43 +0025 Date: Mon, 9 Mar 2015 13:31:43 +0000 From: Bruce Richardson To: Stephen Hemminger Message-ID: <20150309133143.GA7256@bricha3-MOBL3> References: <1425695004-29605-1-git-send-email-stephen@networkplumber.org> <1425695004-29605-2-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425695004-29605-2-git-send-email-stephen@networkplumber.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/5] ixgbe: make txq_ops const X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 13:31:48 -0000 On Fri, Mar 06, 2015 at 06:23:20PM -0800, Stephen Hemminger wrote: > All virtual function tables should be const so they are put > in text segment rather than data. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 2 +- > lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 2 +- > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index 9ecf3e5..e6aec8f 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -1754,7 +1754,7 @@ ixgbe_reset_tx_queue(struct igb_tx_queue *txq) > IXGBE_CTX_NUM * sizeof(struct ixgbe_advctx_info)); > } > > -static struct ixgbe_txq_ops def_txq_ops = { > +static const struct ixgbe_txq_ops def_txq_ops = { > .release_mbufs = ixgbe_tx_queue_release_mbufs, > .free_swring = ixgbe_tx_free_swring, > .reset = ixgbe_reset_tx_queue, > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.h b/lib/librte_pmd_ixgbe/ixgbe_rxtx.h > index 329007c..a85839e 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.h > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.h > @@ -211,7 +211,7 @@ struct igb_tx_queue { > uint32_t ctx_curr; /**< Hardware context states. */ > /** Hardware context0 history. */ > struct ixgbe_advctx_info ctx_cache[IXGBE_CTX_NUM]; > - struct ixgbe_txq_ops *ops; /**< txq ops */ > + const struct ixgbe_txq_ops *ops; /**< txq ops */ > uint8_t tx_deferred_start; /**< not in global dev start. */ > }; > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > index 1f46f0f..11e9f12 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > @@ -723,7 +723,7 @@ ixgbe_reset_tx_queue(struct igb_tx_queue *txq) > IXGBE_CTX_NUM * sizeof(struct ixgbe_advctx_info)); > } > > -static struct ixgbe_txq_ops vec_txq_ops = { > +static const struct ixgbe_txq_ops vec_txq_ops = { > .release_mbufs = ixgbe_tx_queue_release_mbufs, > .free_swring = ixgbe_tx_free_swring, > .reset = ixgbe_reset_tx_queue, > -- > 2.1.4 >