From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 811BE5ABA for ; Mon, 9 Mar 2015 14:43:19 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 09 Mar 2015 06:43:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,367,1422950400"; d="scan'208";a="677298743" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.26]) by fmsmga001.fm.intel.com with SMTP; 09 Mar 2015 06:43:16 -0700 Received: by (sSMTP sendmail emulation); Mon, 09 Mar 2015 13:43:15 +0025 Date: Mon, 9 Mar 2015 13:43:15 +0000 From: Bruce Richardson To: Stephen Hemminger Message-ID: <20150309134315.GD7256@bricha3-MOBL3> References: <1425695004-29605-1-git-send-email-stephen@networkplumber.org> <1425695004-29605-5-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425695004-29605-5-git-send-email-stephen@networkplumber.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 4/5] ixgbe: rename set_tx_function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 13:43:20 -0000 On Fri, Mar 06, 2015 at 06:23:23PM -0800, Stephen Hemminger wrote: > All global functions in a driver should use the same prefix > to avoid any future name collisions. > > Signed-off-by: Stephen Hemminger I think this patch is missing one instance of set_tx_function at line 1963 of ixgbe_rxtx.c that needs to be renamed. /Bruce > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 2 +- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 2 +- > lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > index 9bdc046..e1504f4 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > @@ -753,7 +753,7 @@ eth_ixgbe_dev_init(__attribute__((unused)) struct eth_driver *eth_drv, > * Tx queue may not initialized by primary process */ > if (eth_dev->data->tx_queues) { > txq = eth_dev->data->tx_queues[eth_dev->data->nb_tx_queues-1]; > - set_tx_function(eth_dev, txq); > + ixgbe_set_tx_function(eth_dev, txq); > } else { > /* Use default TX function if we get here */ > PMD_INIT_LOG(INFO, "No TX queues configured yet. " > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index 0f32296..c5ba687 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -1765,7 +1765,7 @@ static const struct ixgbe_txq_ops def_txq_ops = { > * in dev_init by secondary process when attaching to an existing ethdev. > */ > void > -set_tx_function(struct rte_eth_dev *dev, struct igb_tx_queue *txq) > +ixgbe_set_tx_function(struct rte_eth_dev *dev, struct igb_tx_queue *txq) > { > /* Use a simple Tx queue (no offloads, no multi segs) if possible */ > if (((txq->txq_flags & IXGBE_SIMPLE_FLAGS) == IXGBE_SIMPLE_FLAGS) > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.h b/lib/librte_pmd_ixgbe/ixgbe_rxtx.h > index a85839e..42d59f9 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.h > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.h > @@ -253,7 +253,7 @@ struct ixgbe_txq_ops { > * the queue parameters. Used in tx_queue_setup by primary process and then > * in dev_init by secondary process when attaching to an existing ethdev. > */ > -void set_tx_function(struct rte_eth_dev *dev, struct igb_tx_queue *txq); > +void ixgbe_set_tx_function(struct rte_eth_dev *dev, struct igb_tx_queue *txq); > > #ifdef RTE_IXGBE_INC_VECTOR > uint16_t ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, > -- > 2.1.4 >