From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4DAD7683D for ; Mon, 9 Mar 2015 15:02:42 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 09 Mar 2015 07:01:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,368,1422950400"; d="scan'208";a="662524303" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.26]) by orsmga001.jf.intel.com with SMTP; 09 Mar 2015 07:02:38 -0700 Received: by (sSMTP sendmail emulation); Mon, 09 Mar 2015 14:02:38 +0025 Date: Mon, 9 Mar 2015 14:02:37 +0000 From: Bruce Richardson To: xuelin.shi@freescale.com Message-ID: <20150309140237.GB5848@bricha3-MOBL3> References: <1425450852-24837-1-git-send-email-xuelin.shi@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425450852-24837-1-git-send-email-xuelin.shi@freescale.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 14:02:42 -0000 On Wed, Mar 04, 2015 at 02:34:12PM +0800, xuelin.shi@freescale.com wrote: > From: Xuelin Shi > > This module uses type conversion between struct and int. > Also truncation and comparison is used with this int. > It is not safe for different endian arch. > > Add ifdef for big endian struct to fix this issue. > > Signed-off-by: Xuelin Shi > --- > lib/librte_lpm/rte_lpm.h | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/lib/librte_lpm/rte_lpm.h b/lib/librte_lpm/rte_lpm.h > index 1af150c..08a2859 100644 > --- a/lib/librte_lpm/rte_lpm.h > +++ b/lib/librte_lpm/rte_lpm.h > @@ -96,6 +96,7 @@ extern "C" { > /** Bitmask used to indicate successful lookup */ > #define RTE_LPM_LOOKUP_SUCCESS 0x0100 > > +#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN > /** @internal Tbl24 entry structure. */ > struct rte_lpm_tbl24_entry { > /* Stores Next hop or group index (i.e. gindex)into tbl8. */ > @@ -117,6 +118,24 @@ struct rte_lpm_tbl8_entry { > uint8_t valid_group :1; /**< Group validation flag. */ > uint8_t depth :6; /**< Rule depth. */ > }; > +#else > +struct rte_lpm_tbl24_entry { > + uint8_t depth :6; > + uint8_t ext_entry :1; > + uint8_t valid :1; > + union { > + uint8_t tbl8_gindex; > + uint8_t next_hop; > + }; > +}; > + > +struct rte_lpm_tbl8_entry { > + uint8_t depth :6; > + uint8_t valid_group :1; > + uint8_t valid :1; > + uint8_t next_hop; > +}; > +#endif > > /** @internal Rule structure. */ > struct rte_lpm_rule { > -- > 1.9.1 > Get an error compiling this up (using clang on FreeBSD). CC rte_lpm.o In file included from /usr/home/bruce/dpdk.org/lib/librte_lpm/rte_lpm.c:57: /usr/home/bruce/dpdk.org/lib/librte_lpm/rte_lpm.h:99:5: fatal error: 'RTE_BYTE_ORDER' is not defined, evaluates to 0 [-Wundef] #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN ^ 1 error generated. Adding "#include " should fix the issue. Existing unit tests on IA (little endian) pass fine there-after, but I think for this patch it would be good to have an ack from someone who can validate on a big endian system, since this is what this patch is meant to enable. /Bruce