From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com
 [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 70DB05A64
 for <dev@dpdk.org>; Tue, 10 Mar 2015 05:18:55 +0100 (CET)
Received: by pdbnh10 with SMTP id nh10so74182446pdb.4
 for <dev@dpdk.org>; Mon, 09 Mar 2015 21:18:54 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=zAMlPN7JMCjRm7uYsWVx9jvPaR1GpXbsUfbHs6Xt4FM=;
 b=iLg8KaDhjUwsYyUq0IjD8nLK0XavPAG1Vts/dlq0hudS4J6jHQFXO5I9QvY0qsNsTm
 jRkyHVgH4k5QwqsIOARMduUeaKqLPi6QRM3JPz2vkKcFSI9oW9/9T8pQABE038KgSwuf
 etikSATH10I4FEXLR+5CyFCmVCfUvypfVZo9mNfLQqcRFoc6DoCnmqVO6T/bVSpeKizB
 0K2ckQzPPiXTsUEA6zzOFm05XtVXicLxl0BMfg47ZysmRDx9pebbeVgy3wcklY+jFXFx
 mNk9eEZ3XDmlX3RHtjQSBwAQc9fkbnU3NNN7OiD8bPavPG7E8PkK/mdPlr/tf5YAwo/S
 fdHg==
X-Gm-Message-State: ALoCoQmwyDVeXxQJLa6XlXKf1w2GIjIeqd3dCGpQWxsCCVfiix62X9mJfypvBHbDNafo+4E2Ucdu
X-Received: by 10.66.122.204 with SMTP id lu12mr649532pab.52.1425961134639;
 Mon, 09 Mar 2015 21:18:54 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id ff10sm21785424pad.1.2015.03.09.21.18.53
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 09 Mar 2015 21:18:53 -0700 (PDT)
Date: Mon, 9 Mar 2015 21:18:49 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yong Wang <yongwang@vmware.com>
Message-ID: <20150309211849.0dae05d3@urahara>
In-Reply-To: <9bc742bd1778468a815da8070b584ee7@BRMWP-EXMB11.corp.brocade.com>
References: <1425600635-20628-1-git-send-email-stephen@networkplumber.org>
 <1425600635-20628-8-git-send-email-stephen@networkplumber.org>
 <9bc742bd1778468a815da8070b584ee7@BRMWP-EXMB11.corp.brocade.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@Brocade.com>
Subject: Re: [dpdk-dev] [PATCH v3 07/10] vmxnet3: support jumbo frames
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Mar 2015 04:18:55 -0000

On Mon, 9 Mar 2015 23:28:39 +0000
Yong Wang <yongwang@vmware.com> wrote:

> I didn=E2=80=99t see where mtu is used to calculate how many rx descripto=
rs will
> be needed for each packet.  Furthermore, as pointed out by the following
> code comments, the device requires the first rx buffer of a packet be of
> type VMXNET3_RXD_BTYPE_HEAD with the remaining buffers of type
> VMXNET3_RXD_BTYPE_NODY.  This needs to be taken care of when populating rx
> rings in vmxnet3_post_rx_bufs(). Currently we don=E2=80=99t do this becau=
se no
> scatter-rx is supported and only one descriptor is needed for a packet
> (thus all types should be HEAD). Otherwise, the device will complain with
> error returned.  For the 2nd rx ring, type needs to be BODY for all
> descriptors still.

Yeah the reload logic needs work.

> Related to this, could you share what tests have been done to cover these
> new features?

Not really. We only test with our product which is built on top of DPDK,
not standalone.

Most of these came from figuring what features where missing from the DPDK
driver that Intel supplied. I had independently developed a much better
virtio and vmxnet3 drivers which were well tested, but DPDK maintainers
would not accept wholesale replacement of the driver. Therefore we have
been trying to selective add the bits from my driver back into the
Intel driver.