From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 19B0D6A87 for ; Wed, 11 Mar 2015 20:36:27 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YVmQY-00085F-LL; Wed, 11 Mar 2015 15:36:24 -0400 Date: Wed, 11 Mar 2015 15:36:21 -0400 From: Neil Horman To: Thomas Monjalon Message-ID: <20150311193621.GA17688@hmsreliant.think-freely.org> References: <1422652596-12777-1-git-send-email-nhorman@tuxdriver.com> <1425486419-12508-1-git-send-email-nhorman@tuxdriver.com> <4566278.scup7l1psc@xps13> <20150305165727.GB27783@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150305165727.GB27783@hmsreliant.think-freely.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2015 19:36:27 -0000 On Thu, Mar 05, 2015 at 11:57:27AM -0500, Neil Horman wrote: > On Wed, Mar 04, 2015 at 05:49:50PM +0100, Thomas Monjalon wrote: > > 2015-03-04 11:26, Neil Horman: > > > +#trap on ctrl-c to clean up > > > +trap cleanup_and_exit SIGINT > > > > I think INT is preffered over SIGINT. > > You may also add QUIT and TERM. > > With QUIT, you can replace cleanup_and_exit calls by a simple exit. > > > > > + CURRENT_BRANCH=`git log --pretty=format:%H HEAD~1..HEAD` > > > > May be simpler "git log -1 --format=%H" > > > It might be, but the above is equivalent, and --format is a more recent git-log > feature. Older versions still require --pretty=format > > > > +log "INFO" "We're going to check and make sure that applications built" > > > +log "INFO" "against DPDK DSOs from tag $TAG1 will still run when executed" > > > +log "INFO" "against DPDK DSOs built from tag $TAG2." > > > > I think it may be removed as no app is run. > > > The above doesn't indicate that an application will be run, only that the > purpose of this script is to ensure that older applications will still run, > which I think is appropriate. > > > > +# Make sure we configure SHARED libraries > > > +# Also turn off IGB and KNI as those require kernel headers to build > > > +sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET > > > +sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET > > > +sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET > > > > So you prefer modifying defconfig instead of .config, right? > > (you sent it while I was answering on v2) > > > Yes, correct. > > > > +# Checking abi compliance relies on using the dwarf information in > > > +# The shared objects. Thats only included in the DSO's if we build > > > +# with -g > > > +export EXTRA_CFLAGS=-g > > > +export EXTRA_LDFLAGS=-g > > [...] > > > +export EXTRA_CFLAGS=-g > > > +export EXTRA_LDFLAGS=-g > > > > Already exported. > > > Yeah, I'll clean that up later. > > > > + OLDNAME=`basename $i | sed -e"s/1.dump/0.dump/"` > > > > Could be OLDNAME=$(basename $i 1.dump)0.dump > > > > > + LIBNAME=`basename $i | sed -e"s/-ABI-1.dump//"` > > > > Could be LIBNAME=$(basename $i -ABI-1.dump) > > > It could be, but I prefer the clarity of the sed replacement. > > Neil > > > Thanks > > > > > Ping Thomas, is this going to make 2.0? Thanks Neil