From: Bruce Richardson <bruce.richardson@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 01/15] eal: Fix cording style of eal_pci.c and eal_pci_uio.c
Date: Thu, 12 Mar 2015 11:09:02 +0000
Message-ID: <20150312110902.GC10100@bricha3-MOBL3> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286D02B86@SHSMSX101.ccr.corp.intel.com>
On Thu, Mar 12, 2015 at 10:57:18AM +0000, Qiu, Michael wrote:
> On 3/12/2015 6:50 PM, Bruce Richardson wrote:
> > On Thu, Mar 12, 2015 at 07:17:40PM +0900, Tetsuya Mukawa wrote:
> >> This patch fixes cording style of below files in linuxapp and bsdapp.
> >> - eal_pci.c
> >> - eal_pci_uio.c
> >>
> >> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> > Hi Tetsuya,
> >
> > While there is some good cleanup here, I disagree with a number of the changes
> > made purely to the whitespace in the file. The style of using a double-indent
> > for line continuations is very widely used in DPDK code, much more so than the
> > style of lining things up with the previous line.
>
> Yes, but both style are seeing in dpdk, here the patch is using Tab +
> whitespace, which is also
> the linux kernel's style.
>
> So is there any rule to allow only one style?
> Mixed style is bad...
>
> Thanks,
> Michael
No there is no hard rule, that I am aware of. While I prefer the double-indent
myself, that is beside the point that in the absense of a hard rule to be applied
globally, fixing whitespace from style A to style B just increases the size
of the diff which makes it hard to see the real code changes. Even with a slight
mixing of the styles the code is readable enough as-is.
/Bruce
> > So ack to the changes removing unnecessary braces, and occasional splitting of
> > really long lines (though a few chars over 80 is ok). NAK to the whitespace
> > and indentation changes.
> >
> > Regards,
> > /Bruce
> >
> >> ---
> >> lib/librte_eal/bsdapp/eal/eal_pci.c | 67 ++++++++++++++++++-------------
> >> lib/librte_eal/linuxapp/eal/eal_pci.c | 32 +++++++++------
> >> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 37 ++++++++++-------
> >> 3 files changed, 80 insertions(+), 56 deletions(-)
> >>
> >> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
> >> index fe3ef86..cbd0a4e 100644
> >> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c
> >> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
> >> @@ -142,8 +142,9 @@ pci_map_resource(void *requested_addr, const char *devname, off_t offset,
> >> MAP_SHARED, fd, offset);
> >> close(fd);
> >> if (mapaddr == MAP_FAILED ||
> >> - (requested_addr != NULL && mapaddr != requested_addr)) {
> >> - RTE_LOG(ERR, EAL, "%s(): cannot mmap(%s(%d), %p, 0x%lx, 0x%lx):"
> >> + (requested_addr != NULL && mapaddr != requested_addr)) {
> >> + RTE_LOG(ERR, EAL,
> >> + "%s(): cannot mmap(%s(%d), %p, 0x%lx, 0x%lx):"
> >> " %s (%p)\n", __func__, devname, fd, requested_addr,
> >> (unsigned long)size, (unsigned long)offset,
> >> strerror(errno), mapaddr);
> >> @@ -161,9 +162,10 @@ fail:
> >> static int
> >> pci_uio_map_secondary(struct rte_pci_device *dev)
> >> {
> >> - size_t i;
> >> - struct uio_resource *uio_res;
> >> - struct uio_res_list *uio_res_list = RTE_TAILQ_CAST(rte_uio_tailq.head, uio_res_list);
> >> + size_t i;
> >> + struct uio_resource *uio_res;
> >> + struct uio_res_list *uio_res_list =
> >> + RTE_TAILQ_CAST(rte_uio_tailq.head, uio_res_list);
> >>
> >> TAILQ_FOREACH(uio_res, uio_res_list, next) {
> >>
> >> @@ -179,10 +181,10 @@ pci_uio_map_secondary(struct rte_pci_device *dev)
> >> != uio_res->maps[i].addr) {
> >> RTE_LOG(ERR, EAL,
> >> "Cannot mmap device resource\n");
> >> - return (-1);
> >> + return -1;
> >> }
> >> }
> >> - return (0);
> >> + return 0;
> >> }
> >>
> >> RTE_LOG(ERR, EAL, "Cannot find resource for device\n");
> >> @@ -201,7 +203,8 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >> uint64_t pagesz;
> >> struct rte_pci_addr *loc = &dev->addr;
> >> struct uio_resource *uio_res;
> >> - struct uio_res_list *uio_res_list = RTE_TAILQ_CAST(rte_uio_tailq.head, uio_res_list);
> >> + struct uio_res_list *uio_res_list =
> >> + RTE_TAILQ_CAST(rte_uio_tailq.head, uio_res_list);
> >> struct uio_map *maps;
> >>
> >> dev->intr_handle.fd = -1;
> >> @@ -209,14 +212,16 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >>
> >> /* secondary processes - use already recorded details */
> >> if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> >> - return (pci_uio_map_secondary(dev));
> >> + return pci_uio_map_secondary(dev);
> >>
> >> snprintf(devname, sizeof(devname), "/dev/uio@pci:%u:%u:%u",
> >> dev->addr.bus, dev->addr.devid, dev->addr.function);
> >>
> >> if (access(devname, O_RDWR) < 0) {
> >> - RTE_LOG(WARNING, EAL, " "PCI_PRI_FMT" not managed by UIO driver, "
> >> - "skipping\n", loc->domain, loc->bus, loc->devid, loc->function);
> >> + RTE_LOG(WARNING, EAL,
> >> + " "PCI_PRI_FMT" not managed by UIO driver, "
> >> + "skipping\n", loc->domain, loc->bus,
> >> + loc->devid, loc->function);
> >> return 1;
> >> }
> >>
> >> @@ -233,7 +238,7 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >> if ((uio_res = rte_zmalloc("UIO_RES", sizeof (*uio_res), 0)) == NULL) {
> >> RTE_LOG(ERR, EAL,
> >> "%s(): cannot store uio mmap details\n", __func__);
> >> - return (-1);
> >> + return -1;
> >> }
> >>
> >> snprintf(uio_res->path, sizeof(uio_res->path), "%s", devname);
> >> @@ -248,7 +253,8 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >>
> >> j = uio_res->nb_maps;
> >> /* skip empty BAR */
> >> - if ((phaddr = dev->mem_resource[i].phys_addr) == 0)
> >> + phaddr = dev->mem_resource[i].phys_addr;
> >> + if (phaddr == 0)
> >> continue;
> >>
> >> /* if matching map is found, then use it */
> >> @@ -261,7 +267,7 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >> (size_t)maps[j].size)
> >> ) == NULL) {
> >> rte_free(uio_res);
> >> - return (-1);
> >> + return -1;
> >> }
> >>
> >> maps[j].addr = mapaddr;
> >> @@ -271,7 +277,7 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >>
> >> TAILQ_INSERT_TAIL(uio_res_list, uio_res, next);
> >>
> >> - return (0);
> >> + return 0;
> >> }
> >>
> >> /* Scan one pci sysfs entry, and fill the devices list from it. */
> >> @@ -311,7 +317,7 @@ pci_scan_one(int dev_pci_fd, struct pci_conf *conf)
> >> /* FreeBSD has no NUMA support (yet) */
> >> dev->numa_node = 0;
> >>
> >> -/* parse resources */
> >> + /* parse resources */
> >> switch (conf->pc_hdr & PCIM_HDRTYPE) {
> >> case PCIM_HDRTYPE_NORMAL:
> >> max = PCIR_MAX_BAR_0;
> >> @@ -440,32 +446,37 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d
> >>
> >> /* check if device's identifiers match the driver's ones */
> >> if (id_table->vendor_id != dev->id.vendor_id &&
> >> - id_table->vendor_id != PCI_ANY_ID)
> >> + id_table->vendor_id != PCI_ANY_ID)
> >> continue;
> >> if (id_table->device_id != dev->id.device_id &&
> >> - id_table->device_id != PCI_ANY_ID)
> >> + id_table->device_id != PCI_ANY_ID)
> >> continue;
> >> - if (id_table->subsystem_vendor_id != dev->id.subsystem_vendor_id &&
> >> - id_table->subsystem_vendor_id != PCI_ANY_ID)
> >> + if (id_table->subsystem_vendor_id !=
> >> + dev->id.subsystem_vendor_id &&
> >> + id_table->subsystem_vendor_id != PCI_ANY_ID)
> >> continue;
> >> - if (id_table->subsystem_device_id != dev->id.subsystem_device_id &&
> >> - id_table->subsystem_device_id != PCI_ANY_ID)
> >> + if (id_table->subsystem_device_id !=
> >> + dev->id.subsystem_device_id &&
> >> + id_table->subsystem_device_id != PCI_ANY_ID)
> >> continue;
> >>
> >> struct rte_pci_addr *loc = &dev->addr;
> >>
> >> - RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> >> - loc->domain, loc->bus, loc->devid, loc->function,
> >> - dev->numa_node);
> >> + RTE_LOG(DEBUG, EAL,
> >> + "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> >> + loc->domain, loc->bus, loc->devid, loc->function,
> >> + dev->numa_node);
> >>
> >> - RTE_LOG(DEBUG, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
> >> - dev->id.device_id, dr->name);
> >> + RTE_LOG(DEBUG, EAL,
> >> + " probe driver: %x:%x %s\n", dev->id.vendor_id,
> >> + dev->id.device_id, dr->name);
> >>
> >> /* no initialization when blacklisted, return without error */
> >> if (dev->devargs != NULL &&
> >> dev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {
> >>
> >> - RTE_LOG(DEBUG, EAL, " Device is blacklisted, not initializing\n");
> >> + RTE_LOG(DEBUG, EAL,
> >> + " Device is blacklisted, not initializing\n");
> >> return 0;
> >> }
> >>
> >> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
> >> index 83c589e..353b0b8 100644
> >> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> >> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> >> @@ -154,7 +154,8 @@ pci_map_resource(void *requested_addr, int fd, off_t offset, size_t size,
> >> mapaddr = mmap(requested_addr, size, PROT_READ | PROT_WRITE,
> >> MAP_SHARED | additional_flags, fd, offset);
> >> if (mapaddr == MAP_FAILED) {
> >> - RTE_LOG(ERR, EAL, "%s(): cannot mmap(%d, %p, 0x%lx, 0x%lx): %s (%p)\n",
> >> + RTE_LOG(ERR, EAL,
> >> + "%s(): cannot mmap(%d, %p, 0x%lx, 0x%lx): %s (%p)\n",
> >> __func__, fd, requested_addr,
> >> (unsigned long)size, (unsigned long)offset,
> >> strerror(errno), mapaddr);
> >> @@ -631,31 +632,36 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d
> >>
> >> /* check if device's identifiers match the driver's ones */
> >> if (id_table->vendor_id != dev->id.vendor_id &&
> >> - id_table->vendor_id != PCI_ANY_ID)
> >> + id_table->vendor_id != PCI_ANY_ID)
> >> continue;
> >> if (id_table->device_id != dev->id.device_id &&
> >> - id_table->device_id != PCI_ANY_ID)
> >> + id_table->device_id != PCI_ANY_ID)
> >> continue;
> >> - if (id_table->subsystem_vendor_id != dev->id.subsystem_vendor_id &&
> >> - id_table->subsystem_vendor_id != PCI_ANY_ID)
> >> + if (id_table->subsystem_vendor_id !=
> >> + dev->id.subsystem_vendor_id &&
> >> + id_table->subsystem_vendor_id != PCI_ANY_ID)
> >> continue;
> >> - if (id_table->subsystem_device_id != dev->id.subsystem_device_id &&
> >> - id_table->subsystem_device_id != PCI_ANY_ID)
> >> + if (id_table->subsystem_device_id !=
> >> + dev->id.subsystem_device_id &&
> >> + id_table->subsystem_device_id != PCI_ANY_ID)
> >> continue;
> >>
> >> struct rte_pci_addr *loc = &dev->addr;
> >>
> >> - RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> >> - loc->domain, loc->bus, loc->devid, loc->function,
> >> - dev->numa_node);
> >> + RTE_LOG(DEBUG, EAL,
> >> + "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> >> + loc->domain, loc->bus, loc->devid, loc->function,
> >> + dev->numa_node);
> >>
> >> - RTE_LOG(DEBUG, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
> >> - dev->id.device_id, dr->name);
> >> + RTE_LOG(DEBUG, EAL,
> >> + " probe driver: %x:%x %s\n", dev->id.vendor_id,
> >> + dev->id.device_id, dr->name);
> >>
> >> /* no initialization when blacklisted, return without error */
> >> if (dev->devargs != NULL &&
> >> dev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {
> >> - RTE_LOG(DEBUG, EAL, " Device is blacklisted, not initializing\n");
> >> + RTE_LOG(DEBUG, EAL,
> >> + " Device is blacklisted, not initializing\n");
> >> return 1;
> >> }
> >>
> >> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> >> index 2d1c69b..6f229d6 100644
> >> --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> >> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> >> @@ -92,7 +92,8 @@ pci_uio_map_secondary(struct rte_pci_device *dev)
> >> {
> >> int fd, i;
> >> struct mapped_pci_resource *uio_res;
> >> - struct mapped_pci_res_list *uio_res_list = RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> >> + struct mapped_pci_res_list *uio_res_list =
> >> + RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> >>
> >> TAILQ_FOREACH(uio_res, uio_res_list, next) {
> >>
> >> @@ -117,14 +118,16 @@ pci_uio_map_secondary(struct rte_pci_device *dev)
> >> if (mapaddr != uio_res->maps[i].addr) {
> >> if (mapaddr == MAP_FAILED)
> >> RTE_LOG(ERR, EAL,
> >> - "Cannot mmap device resource file %s: %s\n",
> >> - uio_res->maps[i].path,
> >> - strerror(errno));
> >> + "Cannot mmap device resource "
> >> + "file %s: %s\n",
> >> + uio_res->maps[i].path,
> >> + strerror(errno));
> >> else
> >> RTE_LOG(ERR, EAL,
> >> - "Cannot mmap device resource file %s to address: %p\n",
> >> - uio_res->maps[i].path,
> >> - uio_res->maps[i].addr);
> >> + "Cannot mmap device resource "
> >> + "file %s to address: %p\n",
> >> + uio_res->maps[i].path,
> >> + uio_res->maps[i].addr);
> >>
> >> close(fd);
> >> return -1;
> >> @@ -272,7 +275,8 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >> uint64_t phaddr;
> >> struct rte_pci_addr *loc = &dev->addr;
> >> struct mapped_pci_resource *uio_res;
> >> - struct mapped_pci_res_list *uio_res_list = RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> >> + struct mapped_pci_res_list *uio_res_list =
> >> + RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> >> struct pci_map *maps;
> >>
> >> dev->intr_handle.fd = -1;
> >> @@ -286,8 +290,10 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >> /* find uio resource */
> >> uio_num = pci_get_uio_dev(dev, dirname, sizeof(dirname));
> >> if (uio_num < 0) {
> >> - RTE_LOG(WARNING, EAL, " "PCI_PRI_FMT" not managed by UIO driver, "
> >> - "skipping\n", loc->domain, loc->bus, loc->devid, loc->function);
> >> + RTE_LOG(WARNING, EAL,
> >> + " "PCI_PRI_FMT" not managed by UIO driver, "
> >> + "skipping\n", loc->domain, loc->bus,
> >> + loc->devid, loc->function);
> >> return 1;
> >> }
> >> snprintf(devname, sizeof(devname), "/dev/uio%u", uio_num);
> >> @@ -338,12 +344,11 @@ pci_uio_map_resource(struct rte_pci_device *dev)
> >> if (phaddr == 0)
> >> continue;
> >>
> >> -
> >> /* update devname for mmap */
> >> snprintf(devname, sizeof(devname),
> >> SYSFS_PCI_DEVICES "/" PCI_PRI_FMT "/resource%d",
> >> - loc->domain, loc->bus, loc->devid, loc->function,
> >> - i);
> >> + loc->domain, loc->bus, loc->devid,
> >> + loc->function, i);
> >>
> >> /*
> >> * open resource file, to mmap it
> >> @@ -412,7 +417,8 @@ static struct mapped_pci_resource *
> >> pci_uio_find_resource(struct rte_pci_device *dev)
> >> {
> >> struct mapped_pci_resource *uio_res;
> >> - struct mapped_pci_res_list *uio_res_list = RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> >> + struct mapped_pci_res_list *uio_res_list =
> >> + RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> >>
> >> if (dev == NULL)
> >> return NULL;
> >> @@ -431,7 +437,8 @@ void
> >> pci_uio_unmap_resource(struct rte_pci_device *dev)
> >> {
> >> struct mapped_pci_resource *uio_res;
> >> - struct mapped_pci_res_list *uio_res_list = RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> >> + struct mapped_pci_res_list *uio_res_list =
> >> + RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> >>
> >> if (dev == NULL)
> >> return;
> >> --
> >> 1.9.1
> >>
>
>
next prev parent reply other threads:[~2015-03-12 11:09 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 3:11 [dpdk-dev] [PATCH 1/3] BSD: Support Port Hotplug function Tetsuya Mukawa
2015-03-04 3:11 ` [dpdk-dev] [PATCH 2/3] eal, ethdev: Remove CONFIG_RTE_LIBRTE_EAL_HOTPLUG Tetsuya Mukawa
2015-03-04 3:11 ` [dpdk-dev] [PATCH 3/3] doc: Remove BSD limitation from hotplug section of programmer's guide Tetsuya Mukawa
2015-03-06 10:32 ` [dpdk-dev] [PATCH 1/3] BSD: Support Port Hotplug function Iremonger, Bernard
2015-03-09 2:23 ` Tetsuya Mukawa
2015-03-12 10:24 ` Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 00/15] eal: Port Hotplug support for BSD Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 01/15] eal: Fix cording style of eal_pci.c and eal_pci_uio.c Tetsuya Mukawa
2015-03-12 10:48 ` Bruce Richardson
2015-03-12 10:57 ` Qiu, Michael
2015-03-12 11:09 ` Bruce Richardson [this message]
2015-03-13 0:25 ` Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 02/15] eal: Close file descriptor of uio configuration Tetsuya Mukawa
2015-03-13 13:54 ` Iremonger, Bernard
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 03/15] eal: Fix memory leak of pci_uio_map_resource() Tetsuya Mukawa
2015-03-13 14:04 ` Iremonger, Bernard
2015-03-17 9:30 ` [dpdk-dev] [PATCH 0/6] Clean up pci uio implementations Tetsuya Mukawa
2015-03-17 9:30 ` [dpdk-dev] [PATCH 1/6] eal: Fix cording style of eal_pci.c and eal_pci_uio.c Tetsuya Mukawa
2015-03-18 14:29 ` Bruce Richardson
2015-03-18 15:08 ` David Marchand
2015-03-17 9:30 ` [dpdk-dev] [PATCH 2/6] eal: Close file descriptor of uio configuration Tetsuya Mukawa
2015-03-18 15:19 ` David Marchand
2015-03-20 1:53 ` Tetsuya Mukawa
2015-03-19 16:04 ` Iremonger, Bernard
2015-03-20 1:54 ` Tetsuya Mukawa
2015-03-17 9:30 ` [dpdk-dev] [PATCH 3/6] eal: Fix memory leaks and needless incrementation of pci uio implementation Tetsuya Mukawa
2015-03-18 15:39 ` David Marchand
2015-03-20 1:53 ` Tetsuya Mukawa
2015-03-19 16:20 ` Iremonger, Bernard
2015-03-20 1:54 ` Tetsuya Mukawa
2015-03-17 9:30 ` [dpdk-dev] [PATCH 4/6] eal/bsdapp: Change names of pci related data structure Tetsuya Mukawa
2015-03-17 9:30 ` [dpdk-dev] [PATCH 5/6] eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as linuxapp Tetsuya Mukawa
2015-03-17 9:30 ` [dpdk-dev] [PATCH 6/6] eal: Fix interface of pci_map_resource() Tetsuya Mukawa
2015-03-20 9:53 ` Iremonger, Bernard
2015-03-24 4:18 ` Tetsuya Mukawa
2015-03-24 4:18 ` [dpdk-dev] [PATCH v2 0/6] Clean up pci uio implementations Tetsuya Mukawa
2015-03-24 4:18 ` [dpdk-dev] [PATCH v2 1/6] eal: Fix coding style of eal_pci.c and eal_pci_uio.c Tetsuya Mukawa
2015-03-24 4:18 ` [dpdk-dev] [PATCH v2 2/6] eal: Close file descriptor of uio configuration Tetsuya Mukawa
2015-03-24 18:33 ` Stephen Hemminger
2015-03-25 3:17 ` Tetsuya Mukawa
2015-03-25 5:07 ` Stephen Hemminger
2015-03-26 4:19 ` Tetsuya Mukawa
2015-03-26 10:03 ` Iremonger, Bernard
2015-03-27 6:01 ` Tetsuya Mukawa
2015-03-24 4:18 ` [dpdk-dev] [PATCH v2 3/6] eal: Fix memory leaks and needless increment of pci_map_addr Tetsuya Mukawa
2015-03-25 15:00 ` Iremonger, Bernard
2015-03-26 2:44 ` Tetsuya Mukawa
2015-03-24 4:18 ` [dpdk-dev] [PATCH v2 4/6] eal/bsdapp: Change names of pci related data structure Tetsuya Mukawa
2015-03-24 4:18 ` [dpdk-dev] [PATCH v2 5/6] eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as linuxapp Tetsuya Mukawa
2015-03-25 15:27 ` Iremonger, Bernard
2015-03-26 2:50 ` Tetsuya Mukawa
2015-03-26 10:41 ` Iremonger, Bernard
2015-03-27 8:19 ` Tetsuya Mukawa
2015-03-24 4:18 ` [dpdk-dev] [PATCH v2 6/6] eal: Fix interface of pci_map_resource() Tetsuya Mukawa
2015-03-25 15:03 ` Iremonger, Bernard
2015-03-27 8:39 ` [dpdk-dev] [PATCH v3 0/5] Clean up pci uio implementations Tetsuya Mukawa
2015-03-27 8:39 ` [dpdk-dev] [PATCH v3 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c Tetsuya Mukawa
2015-03-27 8:39 ` [dpdk-dev] [PATCH v3 2/5] eal: Close file descriptor of uio configuration Tetsuya Mukawa
2015-03-27 8:39 ` [dpdk-dev] [PATCH v3 3/5] eal: Fix memory leaks and needless increment of pci_map_addr Tetsuya Mukawa
2015-03-27 8:39 ` [dpdk-dev] [PATCH v3 4/5] eal/bsdapp: Change names of pci related data structure Tetsuya Mukawa
2015-03-27 8:39 ` [dpdk-dev] [PATCH v3 5/5] eal: Fix uio mapping differences between linuxapp and bsdapp Tetsuya Mukawa
2015-04-21 13:15 ` [dpdk-dev] [PATCH v3 0/5] Clean up pci uio implementations Iremonger, Bernard
2015-04-23 4:23 ` Tetsuya Mukawa
2015-04-23 8:12 ` Iremonger, Bernard
2015-04-23 9:48 ` Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 04/15] eal: Fix needless incrementation of pci_map_addr Tetsuya Mukawa
2015-03-13 14:49 ` Iremonger, Bernard
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 05/15] eal/bsdapp: Change names of pci related data structure Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 06/15] eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as linuxapp Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 07/15] eal: Fix interface of pci_map_resource() of bsdapp Tetsuya Mukawa
2015-03-12 11:04 ` Bruce Richardson
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 08/15] eal: Add pci_uio_alloc_uio_resource() Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 09/15] eal: Add pci_uio_map_uio_resource_by_index() Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 10/15] eal: Consolidate pci_map and mapped_pci_resource of linuxapp and bsdapp Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 11/15] eal: Consolidate rte_eal_pci_probe/close_one_driver() " Tetsuya Mukawa
2015-03-13 15:03 ` Iremonger, Bernard
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 12/15] eal: Consolidate pci_map/unmap_device() " Tetsuya Mukawa
2015-03-13 15:10 ` Iremonger, Bernard
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 13/15] eal: Consolidate pci_map/unmap_resource() " Tetsuya Mukawa
2015-03-13 15:23 ` Iremonger, Bernard
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 14/15] eal: Consolidate pci uio functions " Tetsuya Mukawa
2015-03-12 10:17 ` [dpdk-dev] [PATCH v2 15/15] eal: Enable Port Hotplug as default in Linux and BSD Tetsuya Mukawa
2015-03-13 15:47 ` Iremonger, Bernard
2015-03-17 8:08 ` Tetsuya Mukawa
2015-03-19 11:41 ` Iremonger, Bernard
2015-03-13 11:46 ` [dpdk-dev] [PATCH v2 00/15] eal: Port Hotplug support for BSD Iremonger, Bernard
2015-03-16 3:36 ` Tetsuya Mukawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312110902.GC10100@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
DPDK patches and discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
dev@dpdk.org
public-inbox-index dev
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git