From: Neil Horman <nhorman@tuxdriver.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7] af_packet: Fix some klocwork errors
Date: Thu, 12 Mar 2015 09:38:46 -0400 [thread overview]
Message-ID: <20150312133846.GA15260@hmsreliant.think-freely.org> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286D02B43@SHSMSX101.ccr.corp.intel.com>
On Thu, Mar 12, 2015 at 10:43:24AM +0000, Qiu, Michael wrote:
> On 3/11/2015 9:34 AM, Ouyang Changchun wrote:
> > Fix possible memory leak issue: free kvlist before return;
> > Fix possible resource lost issue: close qssockfd before return;
> >
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > ---
> > Change in v7:
> > - Remove unnecessary '!= NULL' check before freeing it;
> >
> > Change in v6:
> > - Refine exit point;
> >
> > Change in v5:
> > - Initialize qsockfd with -1;
> >
> > Change in v4:
> > - Check sockfd in internals->rx_queue against 0;
> >
> > Change in v3:
> > - Also close sockets for all queues;
> >
> > Change in v2:
> > - Make the error exit point a common path.
>
> Acked-by: Michael Qiu <michael.qiu@intel.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2015-03-12 13:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 6:42 [dpdk-dev] [PATCH] " Ouyang Changchun
2015-02-26 8:44 ` Pawel Wodkowski
2015-02-27 0:49 ` [dpdk-dev] [PATCH v2] " Ouyang Changchun
2015-02-27 14:04 ` Neil Horman
2015-02-28 0:51 ` Ouyang, Changchun
2015-02-28 1:27 ` [dpdk-dev] [PATCH v3] " Ouyang Changchun
2015-03-09 3:49 ` [dpdk-dev] [PATCH v4] " Ouyang Changchun
2015-03-09 6:38 ` Qiu, Michael
2015-03-09 8:47 ` Ouyang, Changchun
2015-03-09 8:58 ` [dpdk-dev] [PATCH v5] " Ouyang Changchun
2015-03-09 19:25 ` John W. Linville
2015-03-10 3:29 ` [dpdk-dev] [PATCH v6] " Ouyang Changchun
2015-03-10 8:36 ` Pawel Wodkowski
2015-03-10 8:49 ` Ouyang, Changchun
2015-03-10 8:59 ` Pawel Wodkowski
2015-03-10 10:19 ` Thomas Monjalon
2015-03-11 1:18 ` Ouyang, Changchun
2015-03-11 1:34 ` [dpdk-dev] [PATCH v7] " Ouyang Changchun
2015-03-12 10:43 ` Qiu, Michael
2015-03-12 13:38 ` Neil Horman [this message]
2015-03-12 17:09 ` John W. Linville
2015-03-17 21:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312133846.GA15260@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).