From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 1195B5947 for ; Thu, 12 Mar 2015 20:15:48 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YW8a5-0004P2-Lz; Thu, 12 Mar 2015 15:15:46 -0400 Date: Thu, 12 Mar 2015 15:15:40 -0400 From: Neil Horman To: John McNamara Message-ID: <20150312191540.GB15260@hmsreliant.think-freely.org> References: <1426179268-22164-1-git-send-email-john.mcnamara@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426179268-22164-1-git-send-email-john.mcnamara@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: additional parameter in RX callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 19:15:48 -0000 On Thu, Mar 12, 2015 at 04:54:27PM +0000, John McNamara wrote: > > This patch is a minor extension to the recent patchset for RX/TX callbacks > based on feedback from users implementing solutions based on it. > > The patch adds a new parameter to the RX callback to pass in the number of > available RX packets in addition to the number of dequeued packets. > This provides the RX callback functions with additional information > that can be used to decide how packets from a burst are handled. > > The TX callback doesn't require this additional parameter so the RX > and TX callbacks no longer have the same function parameters. As such > the single RX/TX callback has been refactored into two separate callbacks. > > Since this is an API change we hope it can be included in 2.0.0 to avoid > changing the API in a subsequent release. > > > John McNamara (1): > ethdev: added additional packet count parameter to RX callbacks > > examples/rxtx_callbacks/main.c | 3 +- > lib/librte_ether/rte_ethdev.c | 8 ++-- > lib/librte_ether/rte_ethdev.h | 74 ++++++++++++++++++++++++++-------------- > 3 files changed, 54 insertions(+), 31 deletions(-) > > -- > 1.7.4.1 > > Well, we're well past the new feature phase of this cycle, so I would say NACK. I would also suggest that you don't need to modify ABI to accomodate this feature. Instead just document the pkts array to be terminated by a reserved value, so that the callback can determine its size dynamically. You could alternatively create a new api call that allows you to retrieve that information from the context of the callback. Neil