From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 89616590C for <dev@dpdk.org>; Fri, 13 Mar 2015 10:41:37 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 13 Mar 2015 02:41:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,393,1422950400"; d="scan'208";a="466749538" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.28]) by FMSMGA003.fm.intel.com with SMTP; 13 Mar 2015 02:34:39 -0700 Received: by (sSMTP sendmail emulation); Fri, 13 Mar 2015 09:41:34 +0025 Date: Fri, 13 Mar 2015 09:41:33 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Neil Horman <nhorman@tuxdriver.com> Message-ID: <20150313094133.GA5056@bricha3-MOBL3> References: <1426179268-22164-1-git-send-email-john.mcnamara@intel.com> <20150312191540.GB15260@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150312191540.GB15260@hmsreliant.think-freely.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: additional parameter in RX callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 13 Mar 2015 09:41:38 -0000 On Thu, Mar 12, 2015 at 03:15:40PM -0400, Neil Horman wrote: > On Thu, Mar 12, 2015 at 04:54:27PM +0000, John McNamara wrote: > > > > This patch is a minor extension to the recent patchset for RX/TX callbacks > > based on feedback from users implementing solutions based on it. > > > > The patch adds a new parameter to the RX callback to pass in the number of > > available RX packets in addition to the number of dequeued packets. > > This provides the RX callback functions with additional information > > that can be used to decide how packets from a burst are handled. > > > > The TX callback doesn't require this additional parameter so the RX > > and TX callbacks no longer have the same function parameters. As such > > the single RX/TX callback has been refactored into two separate callbacks. > > > > Since this is an API change we hope it can be included in 2.0.0 to avoid > > changing the API in a subsequent release. > > > > > > John McNamara (1): > > ethdev: added additional packet count parameter to RX callbacks > > > > examples/rxtx_callbacks/main.c | 3 +- > > lib/librte_ether/rte_ethdev.c | 8 ++-- > > lib/librte_ether/rte_ethdev.h | 74 ++++++++++++++++++++++++++-------------- > > 3 files changed, 54 insertions(+), 31 deletions(-) > > > > -- > > 1.7.4.1 > > > > > > > Well, we're well past the new feature phase of this cycle, so I would say NACK. > I would also suggest that you don't need to modify ABI to accomodate this > feature. Instead just document the pkts array to be terminated by a reserved > value, so that the callback can determine its size dynamically. You could > alternatively create a new api call that allows you to retrieve that information > from the context of the callback. > > Neil > Yes, I would agree we are past the new feature phase. However, given that we are making a change to the API, and a fairly small change too - adding one extra parameter - we think that the benefit of including this now outweighs any risk of merging the patch. It seems a bit crazy to ship a release with a new API and then immediately change the API straight after release. Is it not better to take the received feedback on the API and fix/improve it pre-release before it gets set-in-stone? /Bruce