From: Neil Horman <nhorman@tuxdriver.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix Wbad-function-cast warning
Date: Mon, 16 Mar 2015 11:45:53 -0400 [thread overview]
Message-ID: <20150316154553.GD16238@hmsreliant.think-freely.org> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2ED005D@IRSMSX103.ger.corp.intel.com>
On Mon, Mar 16, 2015 at 03:04:45PM +0000, Mcnamara, John wrote:
> > -----Original Message-----
> > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > Sent: Monday, March 16, 2015 1:19 PM
> > To: Mcnamara, John
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] eal: fix Wbad-function-cast warning
> >
> >
> > This looks reasonable, but it rather begs the question as to why we need
> > rte_align_floor_int in the first place. Theres only one other call site,
> > and it looks like it could use RTE_PTR_ALIGN_FLOOR just as easily. What
> > about fixing up the second call site and removing the function to save
> > some space?
>
> Hi Neil,
>
> Seems like a good idea. I'll submit a v2.
>
> Does rte_align_floor_int() need to be deprecated in some way or is it okay to just remove it?
>
> John
>
After the 2.0 release you should put a note in the api document, yes, but right
now its not required. Though if you wanted to, I wouldn't stop you :)
Neil
next prev parent reply other threads:[~2015-03-16 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 12:56 John McNamara
2015-03-16 13:19 ` Neil Horman
2015-03-16 15:04 ` Mcnamara, John
2015-03-16 15:45 ` Neil Horman [this message]
2015-03-16 17:05 ` [dpdk-dev] [PATCH v2] " John McNamara
2015-03-16 17:52 ` Neil Horman
2015-03-16 23:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316154553.GD16238@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).