From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id A1DD85A96 for ; Wed, 18 Mar 2015 17:48:14 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YYH8W-0005be-QD; Wed, 18 Mar 2015 12:48:12 -0400 Date: Wed, 18 Mar 2015 12:48:04 -0400 From: Neil Horman To: Stefan Puiu Message-ID: <20150318164804.GB362@hmsreliant.think-freely.org> References: <1422544811-26385-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1426177681-16931-2-git-send-email-sergio.gonzalez.monroy@intel.com> <55096B86.7040303@intel.com> <40763037.Qv1hPgBHv0@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/4] mk: Remove combined library and related options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2015 16:48:15 -0000 On Wed, Mar 18, 2015 at 05:30:12PM +0200, Stefan Puiu wrote: > Hi, > > On Wed, Mar 18, 2015 at 2:59 PM, Thomas Monjalon > wrote: > > Hi Sergio, > > > > Thank you for explaining the situation. > > > > 2015-03-18 12:11, Gonzalez Monroy, Sergio: > >> Given that the patch to remove combined libraries is not welcome, I'll > >> try to explain the current situation so we can agree on the way forward. > >> > >> Currently we have build config option for shared libraries and combined > >> libraries. Thus, this results in four possible combinations when > >> building dpdk: > >> - not combined static > >> - not combined shared > >> - combined static > >> - combined shared > >> > >> The makefile rules/targets for combined are different than for not > >> combined. Thus, we currently have two different files for > >> archive/linking (rte.lib.mk and rte.sharelib.mk). > >> > >> Since having versioning, combined shared libraries build will be broken > >> the moment we add a versioned API, as we do not have a global version > >> map that we use when linking such library. > >> Also in my opinion, we would want to prevent users linking against a > >> combined libdpdk.so that may have different features built-in, with the > >> corresponding debugging difficulties when users > >> report different problems/errors. I think this would defeat many of the > >> advantages of using shared libraries. > >> > >> By removing the combined library build option, we would simplify the > >> build system with only two possible choices: > >> - static > >> - shared > > > > +1 > > I believe that simplification is the way go. > > > >> This would allow us to remove one file (rte.sharelib.mk) and have a > >> single file with archive/linking rules. > >> > >> For the convenience of linking against a single library instead of the > >> multiple dpdk libraries, there are a few ways to go around it: > >> - for combined static lib, we can either have a script to re-archive > >> all libraries into a single/combined library (ie. extract all archives > >> into one directory, the re-archive all objects into a combined library), > >> or use a linker script (ie. GROUP ( -lrte_eal -lrte_malloc ... ) ). > > Would the linker script be provided in the repository or would it be > the responsibility of people building against the DPDK? If I'd need to > make a linker script with the list of libraries to link against, might > as well put that list in my SConstruct / Makefile and be done with it. > So the "write your own linker script" and "just deal with separate > libraries" options don't seem that different to me. > just to level set, I think you're thinking of a linker script in too grand a scale. Technically what we're proposing is a linker script, but its literally a single line. If you want an example take a look at /usr/lib64/libc.so. that said, I think it makes more sense for the linker script in question to be part of the dpdk distribution so that the combined library name picks up new libraries as they are created. > Let me ask you something - I understand your concerns about > simplifying Makefiles and the concerns about versioning. How > significant is the "separate libs" use case? And especially the > "separate libs" in the current division of the code / libraries? I > counted about ~30 libs in 1.8.0 under build/lib. Are there people > using librte_eal without rte_malloc? Or rte_malloc without > rte_mempool? > Highly doubtful/impossible since they are explicitly dependent on one another. > I noticed that some examples I built ended up using --whole-archive > -lrte_eal -lrte_etc.... To me, --whole-archive is one way of saying > "we have lots of libraries with obscure dependencies", maybe reducing > the number of libs might also be a way to make the combined lib > unnecessary? I wouldn't bother with the combined lib if I had 3-4 libs > to link against instead of the number of libs needed now. > This isn't a bad suggestion. combining the low level malloc/mempool/eal libraries into a libdpdk_core probably makes sense. Not sure if doing it right now makes sense (this close to the release). But as a next release goal that seems reasonable. Neil