From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Rx/Tx callbacks in debug mode
Date: Mon, 23 Mar 2015 15:01:24 +0000 [thread overview]
Message-ID: <20150323150124.GB12720@bricha3-MOBL3> (raw)
In-Reply-To: <178390751.P840gF6HAz@xps13>
On Mon, Mar 23, 2015 at 03:31:48PM +0100, Thomas Monjalon wrote:
> Hi,
>
> As you may know, rte_eth_rx_burst() and rte_eth_tx_burst() have a
> debug-specific implementation enabled with RTE_LIBRTE_ETHDEV_DEBUG.
> I'm afraid these implementations have been forgotten when adding
> optional Rx/Tx callbacks. Or is it intended?
>
> What do you think of removing these debug functions and insert extra
> checks with ifdef in an unique function?
The omission was unintentional. I think removing duplicate functions and using a
common version, if possible, is always a good idea, or else things like this
keep happening! :-)
/Bruce
prev parent reply other threads:[~2015-03-23 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 14:31 Thomas Monjalon
2015-03-23 15:01 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323150124.GB12720@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).