From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 0B9AB379E for ; Tue, 24 Mar 2015 16:55:11 +0100 (CET) Received: by pdbcz9 with SMTP id cz9so225073397pdb.3 for ; Tue, 24 Mar 2015 08:55:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=W+muliznZlm7HHmJ5rid+y+UKk6yL3HuFxmgKmMsBm0=; b=HSUT2+a9NmNE3UWwMyEvQWrVL8xgyJZO2PU8pe4vWeRzxZRFxLt+4AO5R9hZVonS+l F2Pavn4ZcKAcDFvvRfmjWOTW08wXV6jEfRNh1fqwoTXICVx6MGyXZE1WFKMGw4lhzuLv +/AR+ZUH4pUpcN61mlvdG/wncXutZKiTI8qNwhNXidKnAOknWBTl/D3OA7seDRjQwCrL VRo9AI9H7EMkyhs6aRK74h7e/KNotkOBNZMtLG7V2HzL/mNsnsXUo812sP2G2bdkyZEz G6au8aa/KTa6Df1eqGAzSYEaq5ltEFn3DLpzbAjL2bXwBcovJfndknkZ6pMupviqk8YW eMSA== X-Gm-Message-State: ALoCoQm4R6TSy4sNWTosjEs757XJ25lCUo4CPbB1oNhBTVn1brDG5YD2Giqudade0hOSW57vnOxI X-Received: by 10.66.139.109 with SMTP id qx13mr8854762pab.110.1427212510315; Tue, 24 Mar 2015 08:55:10 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id mt11sm4607096pbc.20.2015.03.24.08.55.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Mar 2015 08:55:09 -0700 (PDT) Date: Tue, 24 Mar 2015 08:55:13 -0700 From: Stephen Hemminger To: "Ananyev, Konstantin" Message-ID: <20150324085513.0752d9ba@urahara> In-Reply-To: <2601191342CEEE43887BDE71AB9772582140700B@irsmsx105.ger.corp.intel.com> References: <1421994224-2127-1-git-send-email-stephen@networkplumber.org> <2601191342CEEE43887BDE71AB9772582140700B@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2015 15:55:11 -0000 On Mon, 23 Mar 2015 16:45:44 +0000 "Ananyev, Konstantin" wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of stephen@networkplumber.org > > Sent: Friday, January 23, 2015 6:24 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count > > > > From: Stephen Hemminger > > > > The ixgbe driver was including CRC in the transmit packet byte > > count, but not for packets received. > > This was notice when forwarding and > > the number of bytes received was greater than the number of bytes transmitted > > for the same number of packets. Make the driver behave like other > > virtual devices and not include CRC in byte count. Use the same queue > > counters already computed and used for Rx. > > About RX side stats - as I remember it depends to what value hw_stip_crc is set at configure(). > If hw_stip_crc==1, then, yes CRC bytes are not included into QBRC value. > I If hw_stip_crc==0, then CRC bytes are included into QBRC. That is an additional bug! * CRC should never be included in the byte count. This is not how Linux or other drivers report byte count. * the byte count must be symmetrical Rx == Tx The Brocade router always set strip_crc to 1. So did not see the additional bug of CRC being included in byte count.