From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id CED563796
 for <dev@dpdk.org>; Tue, 24 Mar 2015 18:01:10 +0100 (CET)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1YaSCJ-0005Rl-Rn; Tue, 24 Mar 2015 13:01:08 -0400
Date: Tue, 24 Mar 2015 13:00:58 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: John McNamara <john.mcnamara@intel.com>
Message-ID: <20150324170058.GA13924@hmsreliant.think-freely.org>
References: <1427208779-16548-1-git-send-email-john.mcnamara@intel.com>
 <1427208779-16548-2-git-send-email-john.mcnamara@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427208779-16548-2-git-send-email-john.mcnamara@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: added make target to print out system
	info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2015 17:01:11 -0000

On Tue, Mar 24, 2015 at 02:52:59PM +0000, John McNamara wrote:
> Added a 'make system_info' target to print out system info
> related to DPDK. This is intended as output that can be
> attached to bug reports.
> ---
>  mk/rte.sdkroot.mk | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
> index e8423b0..b477d09 100644
> --- a/mk/rte.sdkroot.mk
> +++ b/mk/rte.sdkroot.mk
> @@ -123,3 +123,36 @@ examples examples_clean:
>  %:
>  	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig
>  	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@
> +
> +.PHONY: system_info
> +system_info:
> +	$(Q)echo
> +	$(Q)echo "CC version"
> +	$(Q)echo "=========="
> +	$(Q)$(CC) --version
> +	$(Q)echo
> +
> +	$(Q)echo "DPDK version"
> +	$(Q)echo "============"
> +	$(Q)$(MAKE) showversion
> +	$(Q)echo
> +
> +	$(Q)echo "Git commit"
> +	$(Q)echo "=========="
> +	$(Q)git log --pretty=format:'%H' -1
> +	$(Q)echo
> +
> +	$(Q)echo "Uname"
> +	$(Q)echo "====="
> +	$(Q)uname -srvmpio
> +	$(Q)echo
> +
> +	$(Q)echo "Hugepages"
> +	$(Q)echo "========="
> +	$(Q)grep -i huge /proc/meminfo
> +	$(Q)echo
> +
> +	$(Q)tools/cpu_layout.py
> +
> +	$(Q)tools/dpdk_nic_bind.py --status
> +	$(Q)echo
> -- 
> 1.8.1.4
> 
> 
Nak, for a few reasons:

1) While this target is in a common makefile, at least some of the information
it gathers is operating system specfic (e.g. /proc/meminfo).  This isn't going
to work on BSD, or other operating systems that we might support in the future

2) This is tied to the build system.  Theres no guarantee that users will
diagnose problems only on the system that they built the DPDK on.  

A better solution might be to simply document the sort of information that a bug
reporter is expected to gather, along with some sample tools for doing so.
There are numerous tools to get the above information, both in isolation and in
aggregate.

Neil