From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 45F34379E for ; Wed, 25 Mar 2015 06:07:52 +0100 (CET) Received: by pdbop1 with SMTP id op1so16358187pdb.2 for ; Tue, 24 Mar 2015 22:07:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=or6qeCygC0HrdznVf829ZHBKDdz2hO1WOt9rkrxdbYI=; b=miMskKholhItAInN4p/VLkD6dSM3IHwswELHabZaASUJE+TCDvApsPKCHZTIC10xk+ o39NNaAHfjnJLJLwg9g6Na4QpjhbmazgIgObXRfzColSopmERbwhUBhqm8XBSq9kL9/n EimMtbvzFyhjy+o+OF6iGqSevwV936nJdMN8fE8a43EMwOC/upoodmb/amxWe25PjxSZ aR2/JSQXjz38pKsjYSM+4CIksv6VqU3uMTdUDTq42z2SI44SUtthYnyUvvubWON8tBY7 IfnagQcxSIB1NBENF3Xu9PfrkybvGbp1ZIZbiKvI657Eboob6gqrgCH3nEdkdwBES6pO YWrg== X-Gm-Message-State: ALoCoQl4W3lXxbjlg0Nvk8sR/agBNvDAFyvOiP6TRlm/cFskjyb7dJ46QuDo7eOb+QpNm0aJkaNU X-Received: by 10.66.178.139 with SMTP id cy11mr12458908pac.146.1427260071687; Tue, 24 Mar 2015 22:07:51 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id v9sm1002145pdp.12.2015.03.24.22.07.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Mar 2015 22:07:51 -0700 (PDT) Date: Tue, 24 Mar 2015 22:07:52 -0700 From: Stephen Hemminger To: Tetsuya Mukawa Message-ID: <20150324220752.45b4ca0e@urahara> In-Reply-To: <551228CC.3000507@igel.co.jp> References: <1426584645-28828-7-git-send-email-mukawa@igel.co.jp> <1427170717-13879-1-git-send-email-mukawa@igel.co.jp> <1427170717-13879-3-git-send-email-mukawa@igel.co.jp> <20150324113321.789c96a1@urahara> <551228CC.3000507@igel.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: Close file descriptor of uio configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 05:07:52 -0000 On Wed, 25 Mar 2015 12:17:32 +0900 Tetsuya Mukawa wrote: > On 2015/03/25 3:33, Stephen Hemminger wrote: > > On Tue, 24 Mar 2015 13:18:33 +0900 > > Tetsuya Mukawa wrote: > > > >> When pci_uio_unmap_resource() is called, a file descriptor that is used > >> for uio configuration should be closed. > >> > >> Signed-off-by: Tetsuya Mukawa > >> --- > >> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +++++- > >> 1 file changed, 5 insertions(+), 1 deletion(-) > >> > >> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c > >> index 9cdf24f..f0277be 100644 > >> --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c > >> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c > >> @@ -459,8 +459,12 @@ pci_uio_unmap_resource(struct rte_pci_device *dev) > >> > >> /* close fd if in primary process */ > >> close(dev->intr_handle.fd); > >> - > >> dev->intr_handle.fd = -1; > >> + > >> + /* close cfg_fd if in primary process */ > >> + close(dev->intr_handle.uio_cfg_fd); > >> + dev->intr_handle.uio_cfg_fd = -1; > >> + > >> dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; > >> } > >> #endif /* RTE_LIBRTE_EAL_HOTPLUG */ > > > > For the Qlogic/Broadcom driver it needed the config fd handle, and I added > > generic config space access functions. > > Hi Stephen, > > Is this the patch you mentioned? > http://dpdk.org/dev/patchwork/patch/3024/ > > > Hi David, Bernard, Stephen > > I guess here are works we will need to do. > 1. Add close(dev->config_fd) in Stephen's patch. > 2. Write a patch for uio to merge "dev->intr_handle->uio_cfg_fd" and > "dev->config_fd". > 3. Write a patch for vfio to merge "dev->intr_handle->vfio_cfg_fd" and > "dev->config_fd". > > If we already have these patches, I guess it may be nice to merge above > patches first. > Do you have a suggestion how to merge patches related with pci config fd? > > Thanks, > Tetsuya > Yeah, that is the patch. It reopens config fd, it seems to overlap this.