DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: "Dey, Souvik" <sodey@sonusnet.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Kernel deadlock due to rte_kni
Date: Thu, 26 Mar 2015 08:21:06 -0400	[thread overview]
Message-ID: <20150326122106.GD32299@hmsreliant.think-freely.org> (raw)
In-Reply-To: <BN3PR0301MB1202571AC94550DEAEF89C65DA080@BN3PR0301MB1202.namprd03.prod.outlook.com>

On Thu, Mar 26, 2015 at 11:01:14AM +0000, Dey, Souvik wrote:
> Do you see any benefit of calling netif_rx_ni() and not directly netif_rx() ?
> 
Yes, I see using the ni variant as not being a bug.  kni_net_rx is run from
process context (it runs as a thread created by kthread_create).  netif_rx
assumes execution occurs in interrupt context, so deadlocks like those below can
still occur if you don't disable pre-emption and irqs on the local cpu.
netif_rx_ni (the No Interrupt) variant, does that for you.

Neil

  reply	other threads:[~2015-03-26 12:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 19:39 Dey, Souvik
2015-03-25 20:11 ` Jay Rolette
2015-03-25 20:16   ` Dey, Souvik
2015-03-26 10:46 ` Neil Horman
2015-03-26 11:01   ` Dey, Souvik
2015-03-26 12:21     ` Neil Horman [this message]
2015-03-26 12:32       ` Dey, Souvik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326122106.GD32299@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=dev@dpdk.org \
    --cc=sodey@sonusnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).