From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 107231396 for ; Thu, 26 Mar 2015 13:21:21 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Yb6mZ-0006RT-5i; Thu, 26 Mar 2015 08:21:19 -0400 Date: Thu, 26 Mar 2015 08:21:06 -0400 From: Neil Horman To: "Dey, Souvik" Message-ID: <20150326122106.GD32299@hmsreliant.think-freely.org> References: <20150326104624.GC32299@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Kernel deadlock due to rte_kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2015 12:21:21 -0000 On Thu, Mar 26, 2015 at 11:01:14AM +0000, Dey, Souvik wrote: > Do you see any benefit of calling netif_rx_ni() and not directly netif_rx() ? > Yes, I see using the ni variant as not being a bug. kni_net_rx is run from process context (it runs as a thread created by kthread_create). netif_rx assumes execution occurs in interrupt context, so deadlocks like those below can still occur if you don't disable pre-emption and irqs on the local cpu. netif_rx_ni (the No Interrupt) variant, does that for you. Neil