From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id 57ABB5A9D for ; Fri, 27 Mar 2015 16:47:28 +0100 (CET) Received: by pacwe9 with SMTP id we9so99100087pac.1 for ; Fri, 27 Mar 2015 08:47:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=sA6jWbfZRPbGkei8BDerNr0j+hVjDMf2nBn5iG2YFuU=; b=iY6xeoT8RoCyROJrhCjI/xeRqCM/PHzgfDsvv7y+3RNtNRQmvUTACkVPTgzdGcpHVH 3pQYHGO2sej/RGcKSCRpVwefnwrTKO4LO9ynPdpay1Dxuf3xDncvaacf0QalzdnsIjqB GpF0aM+mf5Vfy+tZ2G380AYJhW0nNSAhUFco26V5BkR7I5dQA1XlBAMdvbyL5N82wxyM IYtgdf/3WIMiWmUxFf6veurW7S5auvCaeisNayKfrrjDo3BFFREG6LhxKBCD4DJbTbDA eBitY9yFn+5H4R5KxLANZZyTeTV58TChay32heRkDV1mYAzXsl2iqDf9G8MqhLmdkCek 2kow== X-Gm-Message-State: ALoCoQkkMOrFs6aDtvG4fpPSn51SER5cxnV1climrkmDDJuKEHlGx3PDaUEs2Skso1RJQpZ5ZfbA X-Received: by 10.66.221.34 with SMTP id qb2mr36679414pac.42.1427471247636; Fri, 27 Mar 2015 08:47:27 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id ef3sm2551408pbc.26.2015.03.27.08.47.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2015 08:47:27 -0700 (PDT) Date: Fri, 27 Mar 2015 08:47:31 -0700 From: Stephen Hemminger To: Pawel Wodkowski Message-ID: <20150327084731.2f0222e2@urahara> In-Reply-To: <1427453761-20019-2-git-send-email-pawelx.wodkowski@intel.com> References: <1427397455-30368-1-git-send-email-pablo.de.lara.guarch@intel.com> <1427453761-20019-1-git-send-email-pawelx.wodkowski@intel.com> <1427453761-20019-2-git-send-email-pawelx.wodkowski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] test: fix strict aliasing rule error in virtual pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 15:47:28 -0000 On Fri, 27 Mar 2015 11:56:00 +0100 Pawel Wodkowski wrote: > Fix strict aliasing rule error seen in gcc 4.4 > > Signed-off-by: Pawel Wodkowski > --- > app/test/virtual_pmd.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c > index 9b07ab1..f163562 100644 > --- a/app/test/virtual_pmd.c > +++ b/app/test/virtual_pmd.c > @@ -75,15 +75,15 @@ virtual_ethdev_start_fail(struct rte_eth_dev *eth_dev __rte_unused) > } > static void virtual_ethdev_stop(struct rte_eth_dev *eth_dev __rte_unused) > { > - struct rte_mbuf *pkt = NULL; > + void *pkt = NULL; > struct virtual_ethdev_private *prv = eth_dev->data->dev_private; > > eth_dev->data->dev_link.link_status = 0; > eth_dev->data->dev_started = 0; > - while (rte_ring_dequeue(prv->rx_queue, (void **)&pkt) != -ENOENT) > + while (rte_ring_dequeue(prv->rx_queue, &pkt) != -ENOENT) > rte_pktmbuf_free(pkt); > > - while (rte_ring_dequeue(prv->tx_queue, (void **)&pkt) != -ENOENT) > + while (rte_ring_dequeue(prv->tx_queue, &pkt) != -ENOENT) > rte_pktmbuf_free(pkt); > } Losing type information doesn't make this better!