From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 66B9E5A41
 for <dev@dpdk.org>; Wed,  8 Apr 2015 13:49:22 +0200 (CEST)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1YfoTv-0004BM-IR; Wed, 08 Apr 2015 07:49:21 -0400
Date: Wed, 8 Apr 2015 07:49:18 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Message-ID: <20150408114918.GC22959@hmsreliant.think-freely.org>
References: <1428441663-3825-1-git-send-email-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1428441663-3825-1-git-send-email-stephen@networkplumber.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/6] test: remove useless memset
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Apr 2015 11:49:22 -0000

On Tue, Apr 07, 2015 at 02:20:58PM -0700, Stephen Hemminger wrote:
> Remove useless memset, since dev_private is created by rte_zmalloc
> it must already be zero.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test/virtual_pmd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c
> index f163562..39ecf80 100644
> --- a/app/test/virtual_pmd.c
> +++ b/app/test/virtual_pmd.c
> @@ -565,8 +565,6 @@ virtual_ethdev_create(const char *name, struct ether_addr *mac_addr,
>  	if (dev_private == NULL)
>  		goto err;
>  
> -	memset(dev_private, 0, sizeof(*dev_private));
> -
>  	snprintf(name_buf, sizeof(name_buf), "%s_rxQ", name);
>  	dev_private->rx_queue = rte_ring_create(name_buf, MAX_PKT_BURST, socket_id,
>  			0);
> -- 
> 2.1.4
> 
> 

For the series
Acked-by: Neil Horman <nhorman@tuxdriver.com>