From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DF46CC314 for ; Tue, 14 Apr 2015 16:21:57 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 14 Apr 2015 07:21:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,576,1422950400"; d="scan'208";a="679904698" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.33]) by orsmga001.jf.intel.com with SMTP; 14 Apr 2015 07:21:54 -0700 Received: by (sSMTP sendmail emulation); Tue, 14 Apr 2015 15:21:53 +0025 Date: Tue, 14 Apr 2015 15:21:53 +0100 From: Bruce Richardson To: "Butler, Siobhan A" Message-ID: <20150414142153.GA3296@bricha3-MOBL3> References: <3571725.20GtF5MAnU@xps13> <0C5AFCA4B3408848ADF2A3073F7D8CC86D58F9C2@IRSMSX109.ger.corp.intel.com> <2232884.6IKBPajdgE@xps13> <0C5AFCA4B3408848ADF2A3073F7D8CC86D590392@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0C5AFCA4B3408848ADF2A3073F7D8CC86D590392@IRSMSX109.ger.corp.intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 14:21:58 -0000 On Wed, Apr 08, 2015 at 07:54:40PM +0000, Butler, Siobhan A wrote: > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Wednesday, April 8, 2015 5:16 PM > > To: Wiles, Keith; Butler, Siobhan A > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] tools brainstorming > > > > 2015-04-08 15:53, Wiles, Keith: > > > One of the biggest problems with any style is helping the developer > > > maintain the style. Using some tool does help and I have used astyle > > > before, not bad code formatter. Here is a few that seem to be reasonable. > > > > > > http://astyle.sourceforge.net/ > > > > > > http://uncrustify.sourceforge.net/ > > > > > > http://sourceforge.net/projects/gcgreatcode/ > > > > I'm not sure it's a good idea to convert the codebase automatically. > > The coding style must be a reference for new patches and they must be > > automatically checked with a dedicated checkpatch tool. > > By forbidding patches which don't comply, the codebase will be naturally > > converted over time. > > > > I didn't review this proposal yet. > > My first comment is that it's too long to read :) When a consensus is done, it > > must be added with a patch with custom checkpatch addition. > Thanks Thomas, agreed it is a bit of a novel :)- I will refactor with the comments supplied so far and post a fresh version tomorrow. > Siobhan > Just wondering here, are we looking to codify what the current predominant coding style in DPDK *is* or what it *should be*? There has been some good discussion on a variety of areas, but if we focus on initially codifying what's there now, some issues become easier to resolve - e.g. discussion of commenting style, since only C89 comments are allowed right now. /Bruce