From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 12F1D5ABA for ; Fri, 24 Apr 2015 17:22:08 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YlfQX-0000UV-88; Fri, 24 Apr 2015 11:22:06 -0400 Date: Fri, 24 Apr 2015 11:22:00 -0400 From: Neil Horman To: Ravi Kerur Message-ID: <20150424152200.GB32445@hmsreliant.think-freely.org> References: <1429824909-9360-1-git-send-email-rkerur@gmail.com> <1429824936-9399-1-git-send-email-rkerur@gmail.com> <20150424135114.GA32445@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2015 15:22:08 -0000 On Fri, Apr 24, 2015 at 08:14:04AM -0700, Ravi Kerur wrote: > On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman wrote: > > > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > > Changes in v7 > > > Remove _setname_ pthread calls. > > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > > > Changes in v6 > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > > > respectively. Plan to use _getname_ in RTE_LOG when available. > > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > > > > > Changes in v5 > > > Rebase to latest code. > > > > > > Changes in v4 > > > None > > > > > > Changes in v3 > > > Changed subject to be more explicit on file name inclusion. > > > > > > Changes in v2 > > > None > > > > > > Changes in v1 > > > eal_thread.c has minor differences between Linux and BSD, move > > > entire file into common directory. > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > > > Rename eal_thread.c to eal_common_thread.c > > > Makefile changes to reflect file move and name change. > > > Fix checkpatch warnings. > > > > > > Signed-off-by: Ravi Kerur > > > --- > > > lib/librte_eal/bsdapp/eal/Makefile | 2 +- > > > lib/librte_eal/bsdapp/eal/eal_thread.c | 152 > > ------------------------------ > > > lib/librte_eal/common/eal_common_thread.c | 147 > > ++++++++++++++++++++++++++++- > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > > +----------------------------- > > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > b/lib/librte_eal/bsdapp/eal/Makefile > > > index 2357cfa..55971b9 100644 > > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > > # workaround for a gcc bug with noreturn attribute > > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > > -CFLAGS_eal_thread.o += -Wno-return-type > > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > > CFLAGS_eal_hpet.o += -Wno-return-type > > > endif > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > index 9a03437..5714b8f 100644 > > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > > @@ -35,163 +35,11 @@ > > > #include > > > #include > > > #include > > > -#include > > > -#include > > > -#include > > > -#include > > > #include > > > > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > -#include > > > - > > > #include "eal_private.h" > > > #include "eal_thread.h" > > > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > > NAK, these are exported symbols, you can't remove them without going > > through the > > deprecation process. > > > > > They are not removed/deleted, they are moved from eal_thread.c to > eal_common_thread.c file since it is common to both Linux and BSD. > Then perhaps you forgot to export the symbol? Its showing up as removed on the ABI checker utility. Neil > Thanks > Ravi > > Regards > > Neil > > > >