DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Qiu, Michael" <michael.qiu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] What to do about UIO breakage in 2.0
Date: Tue, 28 Apr 2015 09:33:24 -0700	[thread overview]
Message-ID: <20150428093324.441d0015@urahara> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E602860466909F@SHSMSX101.ccr.corp.intel.com>

On Tue, 28 Apr 2015 08:07:18 +0000
"Qiu, Michael" <michael.qiu@intel.com> wrote:

> On 4/28/2015 6:06 AM, Stephen Hemminger wrote:
> > I raised the issue, but people seem to be ignoring that fact that igb_uio
> > was broken by the introduction of UIO PCI generic in 2.0.
> 
> What do you mean about igb_uio broken?
> 
> Thanks,
> Michael
> >
> > There are three options:
> >  1. Remove IGB_UIO only use UIO PCI generic.
> >     Downside there is no MSI-X support for UIO PCI generic.
> >  2. Revert UIO PCI generic support
> >  3. Replace both of the above with something better.
> >
> > I am working on #3 but it will not be ready for 2.0.1 and there
> > is no solution for users of 2.0 and any future stable code.
> >
> 

If you use link state interrupt, then the base code in eal_interrupts
is now broken when using igb_uio. The code was changed to work with
uio_pci_generic. The new code does read/write of PCI INTX config and
will not work when using igb_uio which uses MSI-X.

Some possible solutions are:
 1. Remove igb_uio completely 
 2. Revert/remove uio_pci_generic and use old read/write to enable irq
 3. Make code look at driver type (sending patches for that now).
 4. Implement a better UIO method for MSI-X which is what I will submit
    when Rx IRQ support is ready.

      reply	other threads:[~2015-04-28 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 22:06 Stephen Hemminger
2015-04-28  5:48 ` Matthew Hall
2015-04-28  8:07 ` Qiu, Michael
2015-04-28 16:33   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150428093324.441d0015@urahara \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=michael.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).