From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fbl@sysclose.org>
Received: from sender1.zohomail.com (sender1.zohomail.com [74.201.84.162])
 by dpdk.org (Postfix) with ESMTP id 4D00BC9DE
 for <dev@dpdk.org>; Wed, 29 Apr 2015 20:07:08 +0200 (CEST)
Received: from x240.home (177.92.54.65 [177.92.54.65]) by mx.zohomail.com
 with SMTPS id 1430330824975320.92112482938944;
 Wed, 29 Apr 2015 11:07:04 -0700 (PDT)
Date: Wed, 29 Apr 2015 15:07:00 -0300
From: Flavio Leitner <fbl@sysclose.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150429150700.31c765df@x240.home>
In-Reply-To: <CA+PrjLE9FqCR558ZPvk2fwJbmncMfDfTOFaSQYg93VK4wfQuQA@mail.gmail.com>
References: <1430306974-9618-1-git-send-email-huawei.xie@intel.com>
 <5540C29A.9010708@redhat.com>
 <CA+PrjLE9FqCR558ZPvk2fwJbmncMfDfTOFaSQYg93VK4wfQuQA@mail.gmail.com>
X-Mailer: Claws Mail 3.11.1-91-gd9ab79-dirty (GTK+ 2.24.27;
 x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: make vhost lockless enqueue
 configurable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2015 18:07:08 -0000

On Wed, 29 Apr 2015 13:56:58 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-04-29 13:38 GMT+02:00 Panu Matilainen <pmatilai@redhat.com>:
> > On 04/29/2015 02:29 PM, Huawei Xie wrote:
> >>
> >> vhost enabled vSwitch could have their own thread-safe vring
> >> enqueue policy.
> >> Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for vhost lockless
> >> enqueue. Turn it off by default.
> >>
> >> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> >> ---
> >>   config/common_linuxapp        |  1 +
> >>   lib/librte_vhost/vhost_rxtx.c | 24 +++++++++++++++++++++++-
> >>   2 files changed, 24 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/config/common_linuxapp b/config/common_linuxapp
> >> index 0078dc9..7f59499 100644
> >> --- a/config/common_linuxapp
> >> +++ b/config/common_linuxapp
> >> @@ -421,6 +421,7 @@ CONFIG_RTE_KNI_VHOST_DEBUG_TX=n
> >>   #
> >>   CONFIG_RTE_LIBRTE_VHOST=n
> >>   CONFIG_RTE_LIBRTE_VHOST_USER=y
> >> +CONFIG_RTE_LIBRTE_VHOST_LOCKLESS_ENQ=n
> >>   CONFIG_RTE_LIBRTE_VHOST_DEBUG=n
> [...]
> >
> > These things should be runtime configurable, not build options.
> > Please do not assume everybody builds DPDK separately for each and
> > every application that might ever be.
> 
> +1
> Adding new build options must be exceptions and very well justified.

+1, that's specially hard when dpdk is packaged and distributed on
distros like Fedora/RHEL.

fbl